Closed Bug 686405 Opened 9 years ago Closed 8 years ago

remove the debug button and just sleep for 5s

Categories

(Core :: Widget: Android, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: dougt, Assigned: snorp)

References

Details

Attachments

(1 file, 1 obsolete file)

with the newest jimdb (jim's gdb), you really don't need to press a button to continue.  Instead, we can just rip out the press-a-button-to-continue debug intent, and just turn that into a Thread.sleep().
Attached patch patch v.1 (obsolete) — Splinter Review
Attachment #559927 - Flags: review?(snorp)
Comment on attachment 559927 [details] [diff] [review]
patch v.1

Seems ok to me
Attachment #559927 - Flags: review?(snorp) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3950656acf1b - I'm pretty sure that you completely broke every test suite (by either failing to start up, or crashing, dunno which), though it's pretty funny that I was able to star all the failures right up until I realized that you were at 18 of 23 jobs all failed, and the bug 686091 failures were looking a little odd, because they were taking a bit more than 15 seconds.
Assignee: nobody → snorp
Attachment #559927 - Attachment is obsolete: true
Attachment #564209 - Flags: review?(doug.turner)
snorp - do we need the enum WaitForDebugger?
(In reply to Doug Turner (:dougt) from comment #6)
> snorp - do we need the enum WaitForDebugger?

Yeah, we're running the Android main loop for that 5s so I think it's a good idea to have a state for this.
Attachment #564209 - Flags: review?(doug.turner) → review+
OS: Mac OS X → Android
Hardware: x86 → ARM
https://hg.mozilla.org/mozilla-central/rev/bb4562eb08c8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.