686405 - remove the debug button and just sleep for 5s

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Doug Turner (:dougt)]

with the newest jimdb (jim's gdb), you really don't need to press a button to continue.  Instead, we can just rip out the press-a-button-to-continue debug intent, and just turn that into a Thread.sleep().

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 559927 [details] [diff] [review]
patch v.1

Seems ok to me

Comment 3

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/091bdb10d017

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3950656acf1b - I'm pretty sure that you completely broke every test suite (by either failing to start up, or crashing, dunno which), though it's pretty funny that I was able to star all the failures right up until I realized that you were at 18 of 23 jobs all failed, and the bug 686091 failures were looking a little odd, because they were taking a bit more than 15 seconds.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 686405 - remove the debug button and just wait 5s for the debugger

Comment 6

[Doug Turner (:dougt)]

snorp - do we need the enum WaitForDebugger?

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Doug Turner (:dougt) from comment #6)
> snorp - do we need the enum WaitForDebugger?

Yeah, we're running the Android main loop for that 5s so I think it's a good idea to have a state for this.

Comment 8

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb4562eb08c8

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bb4562eb08c8