The default bug view has changed. See this FAQ.

remove the debug button and just sleep for 5s

RESOLVED FIXED in mozilla10

Status

()

Core
Widget: Android
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: dougt, Assigned: snorp)

Tracking

unspecified
mozilla10
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
with the newest jimdb (jim's gdb), you really don't need to press a button to continue.  Instead, we can just rip out the press-a-button-to-continue debug intent, and just turn that into a Thread.sleep().
(Reporter)

Comment 1

6 years ago
Created attachment 559927 [details] [diff] [review]
patch v.1
Attachment #559927 - Flags: review?(snorp)
Comment on attachment 559927 [details] [diff] [review]
patch v.1

Seems ok to me
Attachment #559927 - Flags: review?(snorp) → review+
(Reporter)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/091bdb10d017
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3950656acf1b - I'm pretty sure that you completely broke every test suite (by either failing to start up, or crashing, dunno which), though it's pretty funny that I was able to star all the failures right up until I realized that you were at 18 of 23 jobs all failed, and the bug 686091 failures were looking a little odd, because they were taking a bit more than 15 seconds.
Assignee: nobody → snorp
Created attachment 564209 [details] [diff] [review]
Bug 686405 - remove the debug button and just wait 5s for the debugger
Attachment #559927 - Attachment is obsolete: true
Attachment #564209 - Flags: review?(doug.turner)
(Reporter)

Comment 6

6 years ago
snorp - do we need the enum WaitForDebugger?
(In reply to Doug Turner (:dougt) from comment #6)
> snorp - do we need the enum WaitForDebugger?

Yeah, we're running the Android main loop for that 5s so I think it's a good idea to have a state for this.
(Reporter)

Updated

6 years ago
Attachment #564209 - Flags: review?(doug.turner) → review+
Keywords: checkin-needed

Updated

6 years ago
OS: Mac OS X → Android
Hardware: x86 → ARM
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb4562eb08c8
Keywords: checkin-needed
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/bb4562eb08c8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Blocks: 704414
You need to log in before you can comment on or make changes to this bug.