Closed Bug 686420 Opened 9 years ago Closed 9 years ago

Cancelled events are not shown as cancelled in "Events and Tasks" bar (Today pane)

Categories

(Calendar :: Calendar Views, defect)

Lightning 1.0b5
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: andy, Assigned: merike)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:9.0a1) Gecko/20110912 Firefox/9.0a1
Build ID: 20110912030829

Steps to reproduce:

I cancelled an event in the Calendar view


Actual results:

The event got crossed out in the Calendar view (as described in bug 273279), but there was no visual marker in the "Events ans Tasks" bar


Expected results:

I expected the same visual marker in the "Events and Tasks" bar (crossed out name of event)
Seems like a reasonable expectation unless there is some UX reasoning to not have it this way.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I agree we want this there too.
Attached patch Style today pane events β€” β€” Splinter Review
Actually, only non-allday events are not styled properly in today pane. Also I noticed that cancelled allday events didn't have line-through style in multiday views. This should fix both.

I think there are some other contributors who could review as well, but I'm unsure who of them might be best (or is even doing reviews), please delegate accordingly if you wish.
Assignee: nobody → gasell+mozilla
Attachment #562125 - Flags: review?(philipp)
Comment on attachment 562125 [details] [diff] [review]
Style today pane events

Review of attachment 562125 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=philipp. I'll check this in in a moment.
Attachment #562125 - Flags: review?(philipp) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/7e8510888a51>
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/5528ac40277c>
Target Milestone: Trunk → 1.0b9
Backported to comm-beta <http://hg.mozilla.org/releases/comm-beta/rev/ab3348fa7094>
Target Milestone: 1.0b9 → 1.0b8
You need to log in before you can comment on or make changes to this bug.