The default bug view has changed. See this FAQ.

test cases for MIME headers need refactoring

RESOLVED FIXED in mozilla10

Status

()

Core
Networking
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Julian Reschke, Assigned: Julian Reschke)

Tracking

(Blocks: 1 bug)

Trunk
mozilla10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
(1) They feed the header name into the call, but the function being tested expects only the feed value. That the tests seem to do what they should do seems to be pure luck.

(2) Currently the tests reside in multiple JS files due to historic reasons; consolidate them in a single file.
(Assignee)

Updated

6 years ago
Assignee: nobody → julian.reschke
Target Milestone: --- → mozilla10
(Assignee)

Comment 1

6 years ago
(In reply to Julian Reschke from comment #0)
> (1) They feed the header name into the call, but the function being tested
> expects only the feed value. That the tests seem to do what they should do
> seems to be pure luck.
> ...

For the base class, this was already done for bug 610054.
(Assignee)

Comment 2

6 years ago
Created attachment 565745 [details] [diff] [review]
Proposed patch

Consolidates all Content-Disposition tests in test_MIME_params.js.

Also: all tests check both the filename and the disposition type.
Attachment #565745 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

6 years ago
Comment on attachment 565745 [details] [diff] [review]
Proposed patch

(patch is on top of 610054)
Comment on attachment 565745 [details] [diff] [review]
Proposed patch

> +//  (note: 5987-mode node yet in use, see bug 601933)

"note yet in use", yes?

r=me
Attachment #565745 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 566460 [details] [diff] [review]
Proposed patch

Proposed patch with typo in comment fixed ("node" ->" not")
Attachment #565745 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #566460 - Flags: review?(bzbarsky)
Attachment #566460 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/ceb6b4df17d5

FWIW, having your name and the reviewer in the patch is helpful.
Status: NEW → ASSIGNED
Keywords: checkin-needed
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/ceb6b4df17d5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.