Closed Bug 686429 Opened 9 years ago Closed 8 years ago
test cases for MIME headers need refactoring
(1) They feed the header name into the call, but the function being tested expects only the feed value. That the tests seem to do what they should do seems to be pure luck. (2) Currently the tests reside in multiple JS files due to historic reasons; consolidate them in a single file.
Assignee: nobody → julian.reschke
Target Milestone: --- → mozilla10
(In reply to Julian Reschke from comment #0) > (1) They feed the header name into the call, but the function being tested > expects only the feed value. That the tests seem to do what they should do > seems to be pure luck. > ... For the base class, this was already done for bug 610054.
Consolidates all Content-Disposition tests in test_MIME_params.js. Also: all tests check both the filename and the disposition type.
Attachment #565745 - Flags: review?(bzbarsky)
Comment on attachment 565745 [details] [diff] [review] Proposed patch > +// (note: 5987-mode node yet in use, see bug 601933) "note yet in use", yes? r=me
Attachment #565745 - Flags: review?(bzbarsky) → review+
Proposed patch with typo in comment fixed ("node" ->" not")
Attachment #565745 - Attachment is obsolete: true
Attachment #566460 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ceb6b4df17d5 FWIW, having your name and the reviewer in the patch is helpful.
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.