686464 - Leave it to Android to unpack the content process executable

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Mike Hommey [:glandium]]

Android unpacks stuff living in lib/armeabi-v7a at install time. It however only does so for files named libsomething.so.

Moving plugin-container in that directory, and renaming it to libplugin-container.so would allow this file to be unpacked at install time, instead of unpacking it ourselves in the java glue.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Leave it to Android to unpack the content process executable

This is not something i'd set for review, but it should be good enough as is for the fast start experiment.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Leave it to Android to unpack the content process executable

updated

Comment 3

[Mike Hommey [:glandium]]

Attachment: Leave it to Android to unpack the content process executable

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 560039 [details] [diff] [review]
Leave it to Android to unpack the content process executable

Review of attachment 560039 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/app/Makefile.in
@@ +46,5 @@
>  
>  include $(topsrcdir)/ipc/app/defs.mk
>  PROGRAM = $(MOZ_CHILD_PROCESS_NAME)
>  
> +$(PROGRAM): $(dir $(PROGRAM))

n.b.: this could use the work in bug 680246 when that lands.

::: ipc/app/defs.mk
@@ +38,3 @@
>  MOZ_CHILD_PROCESS_NAME := plugin-container$(BIN_SUFFIX)
> +else
> +MOZ_CHILD_PROCESS_NAME := lib/libplugin-container.so

This could stand a brief comment explaining why.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f97dc2af18e

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7f97dc2af18e