Last Comment Bug 686464 - Leave it to Android to unpack the content process executable
: Leave it to Android to unpack the content process executable
Status: RESOLVED FIXED
[mobilestartupshrink][inbound]
:
Product: Core
Classification: Components
Component: Widget: Android (show other bugs)
: Trunk
: ARM Android
: -- normal (vote)
: mozilla10
Assigned To: Mike Hommey [:glandium]
:
Mentors:
Depends on: 698213
Blocks: 686480
  Show dependency treegraph
 
Reported: 2011-09-13 08:42 PDT by Mike Hommey [:glandium]
Modified: 2011-10-30 00:40 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Leave it to Android to unpack the content process executable (2.89 KB, patch)
2011-09-13 08:43 PDT, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
Leave it to Android to unpack the content process executable (4.95 KB, patch)
2011-09-13 10:06 PDT, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
Leave it to Android to unpack the content process executable (5.36 KB, patch)
2011-09-13 14:37 PDT, Mike Hommey [:glandium]
ted: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2011-09-13 08:42:24 PDT
Android unpacks stuff living in lib/armeabi-v7a at install time. It however only does so for files named libsomething.so.

Moving plugin-container in that directory, and renaming it to libplugin-container.so would allow this file to be unpacked at install time, instead of unpacking it ourselves in the java glue.
Comment 1 Mike Hommey [:glandium] 2011-09-13 08:43:50 PDT
Created attachment 559961 [details] [diff] [review]
Leave it to Android to unpack the content process executable

This is not something i'd set for review, but it should be good enough as is for the fast start experiment.
Comment 2 Mike Hommey [:glandium] 2011-09-13 10:06:47 PDT
Created attachment 559981 [details] [diff] [review]
Leave it to Android to unpack the content process executable

updated
Comment 3 Mike Hommey [:glandium] 2011-09-13 14:37:15 PDT
Created attachment 560039 [details] [diff] [review]
Leave it to Android to unpack the content process executable
Comment 4 Ted Mielczarek [:ted.mielczarek] 2011-09-23 10:39:10 PDT
Comment on attachment 560039 [details] [diff] [review]
Leave it to Android to unpack the content process executable

Review of attachment 560039 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/app/Makefile.in
@@ +46,5 @@
>  
>  include $(topsrcdir)/ipc/app/defs.mk
>  PROGRAM = $(MOZ_CHILD_PROCESS_NAME)
>  
> +$(PROGRAM): $(dir $(PROGRAM))

n.b.: this could use the work in bug 680246 when that lands.

::: ipc/app/defs.mk
@@ +38,3 @@
>  MOZ_CHILD_PROCESS_NAME := plugin-container$(BIN_SUFFIX)
> +else
> +MOZ_CHILD_PROCESS_NAME := lib/libplugin-container.so

This could stand a brief comment explaining why.
Comment 6 Ed Morley [:emorley] 2011-10-28 04:40:58 PDT
https://hg.mozilla.org/mozilla-central/rev/7f97dc2af18e

Note You need to log in before you can comment on or make changes to this bug.