Leave it to Android to unpack the content process executable

RESOLVED FIXED in mozilla10

Status

()

Core
Widget: Android
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

Trunk
mozilla10
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobilestartupshrink][inbound])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Android unpacks stuff living in lib/armeabi-v7a at install time. It however only does so for files named libsomething.so.

Moving plugin-container in that directory, and renaming it to libplugin-container.so would allow this file to be unpacked at install time, instead of unpacking it ourselves in the java glue.
(Assignee)

Comment 1

6 years ago
Created attachment 559961 [details] [diff] [review]
Leave it to Android to unpack the content process executable

This is not something i'd set for review, but it should be good enough as is for the fast start experiment.
(Assignee)

Updated

6 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Updated

6 years ago
Blocks: 686480
(Assignee)

Comment 2

6 years ago
Created attachment 559981 [details] [diff] [review]
Leave it to Android to unpack the content process executable

updated
(Assignee)

Updated

6 years ago
Attachment #559961 - Attachment is obsolete: true
(Assignee)

Comment 3

6 years ago
Created attachment 560039 [details] [diff] [review]
Leave it to Android to unpack the content process executable
(Assignee)

Updated

6 years ago
Attachment #559981 - Attachment is obsolete: true
Whiteboard: [mobilestartupshrink]
(Assignee)

Updated

6 years ago
Attachment #560039 - Flags: review?(ted.mielczarek)
Comment on attachment 560039 [details] [diff] [review]
Leave it to Android to unpack the content process executable

Review of attachment 560039 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/app/Makefile.in
@@ +46,5 @@
>  
>  include $(topsrcdir)/ipc/app/defs.mk
>  PROGRAM = $(MOZ_CHILD_PROCESS_NAME)
>  
> +$(PROGRAM): $(dir $(PROGRAM))

n.b.: this could use the work in bug 680246 when that lands.

::: ipc/app/defs.mk
@@ +38,3 @@
>  MOZ_CHILD_PROCESS_NAME := plugin-container$(BIN_SUFFIX)
> +else
> +MOZ_CHILD_PROCESS_NAME := lib/libplugin-container.so

This could stand a brief comment explaining why.
Attachment #560039 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f97dc2af18e
Whiteboard: [mobilestartupshrink] → [mobilestartupshrink][inbound]

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/7f97dc2af18e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
(Assignee)

Updated

6 years ago
Depends on: 698213
You need to log in before you can comment on or make changes to this bug.