Closed Bug 686464 Opened 9 years ago Closed 8 years ago

Leave it to Android to unpack the content process executable

Categories

(Core :: Widget: Android, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

(Whiteboard: [mobilestartupshrink][inbound])

Attachments

(1 file, 2 obsolete files)

Android unpacks stuff living in lib/armeabi-v7a at install time. It however only does so for files named libsomething.so.

Moving plugin-container in that directory, and renaming it to libplugin-container.so would allow this file to be unpacked at install time, instead of unpacking it ourselves in the java glue.
This is not something i'd set for review, but it should be good enough as is for the fast start experiment.
Assignee: nobody → mh+mozilla
Blocks: 686480
Attachment #559961 - Attachment is obsolete: true
Attachment #559981 - Attachment is obsolete: true
Whiteboard: [mobilestartupshrink]
Attachment #560039 - Flags: review?(ted.mielczarek)
Comment on attachment 560039 [details] [diff] [review]
Leave it to Android to unpack the content process executable

Review of attachment 560039 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/app/Makefile.in
@@ +46,5 @@
>  
>  include $(topsrcdir)/ipc/app/defs.mk
>  PROGRAM = $(MOZ_CHILD_PROCESS_NAME)
>  
> +$(PROGRAM): $(dir $(PROGRAM))

n.b.: this could use the work in bug 680246 when that lands.

::: ipc/app/defs.mk
@@ +38,3 @@
>  MOZ_CHILD_PROCESS_NAME := plugin-container$(BIN_SUFFIX)
> +else
> +MOZ_CHILD_PROCESS_NAME := lib/libplugin-container.so

This could stand a brief comment explaining why.
Attachment #560039 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f97dc2af18e
Whiteboard: [mobilestartupshrink] → [mobilestartupshrink][inbound]
https://hg.mozilla.org/mozilla-central/rev/7f97dc2af18e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Depends on: 698213
You need to log in before you can comment on or make changes to this bug.