Last Comment Bug 686558 - Fix nsNetUtil.h warning about "enumeral mismatch"
: Fix nsNetUtil.h warning about "enumeral mismatch"
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla9
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on: 272541
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-13 14:53 PDT by Jason Duell [:jduell] (needinfo me)
Modified: 2011-09-29 00:56 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
get rid of gcc warning (1.26 KB, patch)
2011-09-13 14:55 PDT, Jason Duell [:jduell] (needinfo me)
jduell.mcbugs: review+
Details | Diff | Splinter Review

Description Jason Duell [:jduell] (needinfo me) 2011-09-13 14:53:40 PDT
The fix for bug 272541 makes gcc spit out a warning about 

nsNetUtil.h:1951:32: warning: enumeral mismatch in conditional expression: ‘nsIChannel::<anonymous enum>’ vs ‘nsIChannel::<anonymous enum>

Not sure why gcc objects to the tertiary operator being used here, yet "if..else" works ok, but it does.
Comment 1 Jason Duell [:jduell] (needinfo me) 2011-09-13 14:55:35 PDT
Created attachment 560041 [details] [diff] [review]
get rid of gcc warning
Comment 2 Josh Matthews [:jdm] 2011-09-13 15:02:25 PDT
Can we just let bug 585099 take care of this instead?
Comment 3 Jason Duell [:jduell] (needinfo me) 2011-09-13 15:12:30 PDT
Comment on attachment 560041 [details] [diff] [review]
get rid of gcc warning

got verbal +r from bz
Comment 4 Jason Duell [:jduell] (needinfo me) 2011-09-13 15:49:46 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/52418d4fe38b
Comment 5 Matt Brubeck (:mbrubeck) 2011-09-14 06:59:03 PDT
https://hg.mozilla.org/mozilla-central/rev/52418d4fe38b

Note You need to log in before you can comment on or make changes to this bug.