686658 - The 'Select Your Add-Ons' window should have a window title

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Andreas Jung]

The 'Select Your Add-Ons' window does not have a window title.
This means that in the taskbar you get a taskbar button with only an icon but no text, which is quite useless.

I think the window should have a title so that the taskbar button contains it.
Otherwise you are left completely clueless what kind of window is open when the window is in the background (and therefore only the taskbar button visible).

Comment 1

[:aceman]

Can you attach a screenshot? What version of Firefox is it?

Comment 2

[Andreas Jung]

Attachment: screenshot

The bug existed ever since the feature landed.
(I.e. only Firefox 9 nightlies, I think.)

Note that this screenshot is a bit older than the age of this bug,
but I verified that the problem still exists.

Comment 3

[:aceman]

I think this feature is there since FF8.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

This was intentional as per bug 596343 comment 109. But the taskbar issue wasn't discussed in bug 596343 - CC'ing faaborg.

Note: Windows lets applications specify different text for what's shown in a window's titlebar, and what's shown in the taskbar. But AFAIK, we have no API that exposes that.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

Exposing text in the taskbar is important, if the only way to fix that right now is to have a window title that's fine. (what we were trying to avoid was the normal wizard UI that has 3 identical titles all next to each other, cleaner to just have 1).

Comment 6

[Dave Townsend [:mossop]]

So what title should we use here?

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

"Select Your Add-ons" (same as the title in content, right?)

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Since this only affects Windows and Linux (depending on the distro), Mac could keep the blank title.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

yeah that would be great, additional text messes up relative discoverability, so one title is more title-ish than 2 or 3 identical titles.

Comment 10

[Jennifer Morrow [:Boriss] (UX)]

I'm removing "uiwanted" and seconding what Faaborg said - let's add "Select Your Add-ons" as the title for Windows and Linux, but not change the window for OSX.  Rstrong, do you know who we could assign this to?

Comment 11

[Robert Strong (they/them - no direct email)]

Blair or Dave (both already cc'd) would likely be better able to find someone to assign this to.

Comment 12

[Sachin Hosmani [:sachin]]

Could I fix this?
Will it be enough if I set the title attribute of the window element?
How do I keep the title blank in only in Mac?
Is there some way of finding out if Mac is the OS?

Comment 13

[Dave Townsend [:mossop]]

(In reply to Sachin Hosmani from comment #12)
> Could I fix this?
> Will it be enough if I set the title attribute of the window element?
> How do I keep the title blank in only in Mac?
> Is there some way of finding out if Mac is the OS?

XUL files can be pre-processed so you can do different things on different platforms so it should be fairly straightforward to fix. That said we don't have any intention to use this dialog again so I don't think it is worth anyone's time to work on this.