Last Comment Bug 686775 - External API version of StripWhitespace fails to strip \b
: External API version of StripWhitespace fails to strip \b
Status: RESOLVED FIXED
[good first bug]
:
Product: Core
Classification: Components
Component: String (show other bugs)
: unspecified
: All All
: -- minor (vote)
: mozilla11
Assigned To: Atul Aggarwal
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-14 14:35 PDT by neil@parkwaycc.co.uk
Modified: 2011-11-28 05:18 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.57 KB, patch)
2011-11-09 01:30 PST, Atul Aggarwal
benjamin: review+
Details | Diff | Splinter Review

Description neil@parkwaycc.co.uk 2011-09-14 14:35:39 PDT
The internal API version of StripWhitespace strips kWhitespace which is defined to be "\b\t\r\n "; however the external API version of StripWhitespace uses " \t\n\r" and " \t\r\n" thus overlooking the "\b".
Comment 1 Jim Porter (:squib) 2011-09-19 07:51:30 PDT
What does it mean to strip \b? Isn't that a zero-width match?
Comment 2 neil@parkwaycc.co.uk 2011-09-19 08:08:43 PDT
You're thinking regexp. This is a string literal, so it's backspace.
Comment 3 Atul Aggarwal 2011-11-09 01:30:39 PST
Created attachment 573139 [details] [diff] [review]
Patch v1
Comment 5 Marco Bonardo [::mak] 2011-11-28 05:18:57 PST
https://hg.mozilla.org/mozilla-central/rev/4dc32cede297

Note You need to log in before you can comment on or make changes to this bug.