686830 - Stop TinderboxPrinting num_ctors twice

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Phil Ringnalda (:philor)]

Linux builds have a buildstep

========= Started tinderboxprint_ctors (results: 0, elapsed: 0 secs) ==========
TinderboxPrint: num_ctors: 338
======== Finished tinderboxprint_ctors (results: 0, elapsed: 0 secs) ========

and then three steps later have another

========= Started graph server post results complete (results: 0, elapsed: 0 secs) ==========
python /builds/slave/try-lnx/tools/buildfarm/utils/retry.py -s 5 -t 120 -r 8 python /builds/slave/try-lnx/tools/buildfarm/utils/graph_server_post.py --server graphs.mozilla.org --selector /server/collect.cgi --branch Try --buildid 20110914162317 --sourcestamp 9528112e8725 --resultsname Linux_try --properties-file properties.json --timestamp 1316042581
 in dir /builds/slave/try-lnx/build (timeout 1200 secs)
 watching logfiles {}
 argv: ['python', '/builds/slave/try-lnx/tools/buildfarm/utils/retry.py', '-s', '5', '-t', '120', '-r', '8', 'python', '/builds/slave/try-lnx/tools/buildfarm/utils/graph_server_post.py', '--server', 'graphs.mozilla.org', '--selector', '/server/collect.cgi', '--branch', 'Try', '--buildid', '20110914162317', '--sourcestamp', '9528112e8725', '--resultsname', 'Linux_try', '--properties-file', 'properties.json', '--timestamp', '1316042581']
 environment:
(...)
 using PTY: False
Calling <function run_with_timeout at 0xb7c9a064> with args: (['python', '/builds/slave/try-lnx/tools/buildfarm/utils/graph_server_post.py', '--server', 'graphs.mozilla.org', '--selector', '/server/collect.cgi', '--branch', 'Try', '--buildid', '20110914162317', '--sourcestamp', '9528112e8725', '--resultsname', 'Linux_try', '--properties-file', 'properties.json', '--timestamp', '1316042581'], 120, None, None, False, True), kwargs: {}, attempt #1
Executing: ['python', '/builds/slave/try-lnx/tools/buildfarm/utils/graph_server_post.py', '--server', 'graphs.mozilla.org', '--selector', '/server/collect.cgi', '--branch', 'Try', '--buildid', '20110914162317', '--sourcestamp', '9528112e8725', '--resultsname', 'Linux_try', '--properties-file', 'properties.json', '--timestamp', '1316042581']
Process stdio:
TinderboxPrint: <a title="num_ctors" href='http://graphs.mozilla.org/graph.html#tests=[{"test":81,"branch":23,"machine":748}]'>num_ctors:338</a>


Process stderr:

program finished with exit code 0
elapsedTime=0.940740
======== Finished graph server post results complete (results: 0, elapsed: 0 secs) ========

Because tbpl has a bogus regex, bug 582697 comment 1, it hides both of them, but if it didn't, it would look just as silly as Tinderbox does, showing

num_ctors: 338
num_ctors: 338

with the second one linked and the first one unhelpful. If the graph server post step fails, and we don't get the linked TinderboxPrint back, fine, we'll just lose it for anyone who doesn't actually look in the log (since the step before the first TinderboxPrint is a set props that shows it).

Comment 1

[Phil Ringnalda (:philor)]

Attachment: utterly untested fix v.1

Good thing you really love these completely untested in any way copy-paste patches of mine :)

Comment 2

[Chris Cooper [:coop] (he/him)]

Comment on attachment 562981 [details] [diff] [review]
utterly untested fix v.1

(In reply to Phil Ringnalda (:philor) from comment #1)
> Good thing you really love these completely untested in any way copy-paste
> patches of mine :)

I love them more than rolling an untested patch myself. ;)

https://hg.mozilla.org/build/buildbotcustom/rev/a3e018aec72f