686854 - Add google search tab bugzilla.mozilla.org

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[David Lawrence [:dkl]]

Attachment: Patch to add google search tab to query.cgi (v1)

Add a new tab to query.cgi that allows user to search google for bugs in BMO.

Comment 1

[:glob ✱]

Comment on attachment 560323 [details] [diff] [review]
Patch to add google search tab to query.cgi (v1)

i don't think we need to mention google four times _and_ include the google logo image.

please drop the image, and change the text on the search button from "google search" to "search".


>+  # The Original Code is the Google Extension 
>+  #
>+  # The Initial Developer of the Original Code is the Mozilla Corporation
>+  # Corporation. Portions created by Netscape are
>+  # Copyright (C) 1998 Netscape Communications Corporation. All
>+  # Rights Reserved.

please fix the boilerplate :)

Comment 2

[David Lawrence [:dkl]]

Attachment: Patch to add google search tab to query.cgi (v2)

New patch with fixes.

dkl

Comment 3

[:glob ✱]

Comment on attachment 560395 [details] [diff] [review]
Patch to add google search tab to query.cgi (v2)

r=glob

Comment 4

[David Lawrence [:dkl]]

Thanks glob. This should be in production hopefully with the next update someday soon.

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified Bugzilla/Search.pm
added template/en/default/search/search-google.html.tmpl
modified template/en/default/search/tabs.html.tmpl
Committed revision 7875.

dkl