686900 - Make the primordial Function and Object bootstrapping not use functionality itself depending on bootstrapping having partially occurred

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Object and Function initialization are intricately intertwined.  To initialize Object, you need Function to be initialized for the function properties on Object.prototype and Object.  But to initialize Function, you need Object.prototype for Function.prototype's [[Prototype]]!  Since the two are so intricately interdependent, their bootstrapping should be one-off and not use functionality that thinks that these things have already been bootstrapped -- they should do it from scratch.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: 1 - Move js_InitObjectClass to GlobalObject code

All this stuff will live in vm/GlobalObject.cpp, so first I'm moving the sub-bits of this to there.

Comment 2

[Jeff Walden [:Waldo]]

Attachment: 2 - Move js_InitFunctionClass to GlobalObject code

Comment 3

[Jeff Walden [:Waldo]]

Attachment: 3 - Rewrite js_InitFunctionAndObjectClasses

The pièce de résistance!  The sine qua non!  The cliched concluding phrase!

Comment 4

[Luke Wagner [:luke]]

Or: "Object initialization shouldn't involve a fixed-point computation" :)

Comment 5

[Jason Orendorff [:jorendorff]]

Comment on attachment 560387 [details] [diff] [review]
3 - Rewrite js_InitFunctionAndObjectClasses

Looks great. The new code is a little longer but the strange loops in the old code were far from obvious. I don't suppose we can rip out the protection around resolve hooks now, can we?

Comment 6

[Jason Orendorff [:jorendorff]]

Filed bug 687113 for simplifying that stuff. Someone take it--it's a nice opportunity to improve behavior and delete code at the same time!

Comment 7

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2778cb07c697
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae99d33a2290
https://hg.mozilla.org/integration/mozilla-inbound/rev/be380e98f383

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/2778cb07c697
https://hg.mozilla.org/mozilla-central/rev/ae99d33a2290
https://hg.mozilla.org/mozilla-central/rev/be380e98f383