686936 - Switch suite/browser and suite/common to use GetIntPref helper

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

Attachment: Make the switch [Checked in: Comment 4]

Bug 686386 introduced a helper for getIntPref so should switch suite/browser and suite/common to use it.
This patch does that.

Comment 1

[[e-mail]]

Comment on attachment 560436 [details] [diff] [review]
Make the switch [Checked in: Comment 4]

>+          uriArray = [history.lastPageVisited];
How do we know that lastPageVisited won't throw? Possible scenario: create new profile, start with editor, set prefs to show last page visited, open browser.

>+    if (GetIntPref(pref, 2) != MOUSE_SCROLL_ZOOM)
Where does the 2 come from?

Comment 2

[Ian Neal]

(In reply to [e-mail] from comment #1)
> Comment on attachment 560436 [details] [diff] [review]
> Make the switch
> 
> >+    if (GetIntPref(pref, 2) != MOUSE_SCROLL_ZOOM)
> Where does the 2 come from?
It's not 3 which is what MOUSE_SCROLL_ZOOM is.

Comment 3

[[e-mail]]

(In reply to comment #1)
> (From update of attachment 560436 [details] [diff] [review])
> >+          uriArray = [history.lastPageVisited];
> How do we know that lastPageVisited won't throw?
I looked and it doesn't throw, so that's OK.

(In reply to Ian Neal from comment #2)
> (In reply to comment #1)
> > (From update of attachment 560436 [details] [diff] [review])
> > >+    if (GetIntPref(pref, 2) != MOUSE_SCROLL_ZOOM)
> > Where does the 2 come from?
> It's not 3 which is what MOUSE_SCROLL_ZOOM is.
Well if it's an arbitrary value then you might as well use 0.

Comment 4

[Ian Neal]

Comment on attachment 560436 [details] [diff] [review]
Make the switch [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/6d68cf105f8d