Last Comment Bug 686948 - Add Telemetry for hit rate & revalidation rate
: Add Telemetry for hit rate & revalidation rate
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: Cache (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla9
Assigned To: OFFLINE UNTIL 27 FEB 2017 Nicholas Hurley [:nwgh][:hurley] (also hurley@todesschaf.org)
:
: Patrick McManus [:mcmanus]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-15 13:45 PDT by OFFLINE UNTIL 27 FEB 2017 Nicholas Hurley [:nwgh][:hurley] (also hurley@todesschaf.org)
Modified: 2013-05-21 22:25 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch from work time (7.12 KB, patch)
2011-09-15 13:54 PDT, OFFLINE UNTIL 27 FEB 2017 Nicholas Hurley [:nwgh][:hurley] (also hurley@todesschaf.org)
mcmanus: review+
Details | Diff | Splinter Review
Patch update (7.11 KB, patch)
2011-09-16 13:12 PDT, OFFLINE UNTIL 27 FEB 2017 Nicholas Hurley [:nwgh][:hurley] (also hurley@todesschaf.org)
hurley: review+
Details | Diff | Splinter Review

Description User image OFFLINE UNTIL 27 FEB 2017 Nicholas Hurley [:nwgh][:hurley] (also hurley@todesschaf.org) 2011-09-15 13:45:39 PDT
We want to collect telemetry for the following bits of information:

Cache hit (without revalidation from the server)
Successful revalidation (hit with network overhead)
Failed revalidation (we have an entry but after asking the server it can no longer be used)
Cache miss (no entry in the cache)
Comment 1 User image OFFLINE UNTIL 27 FEB 2017 Nicholas Hurley [:nwgh][:hurley] (also hurley@todesschaf.org) 2011-09-15 13:54:57 PDT
Created attachment 560448 [details] [diff] [review]
patch from work time
Comment 2 User image Patrick McManus [:mcmanus] 2011-09-16 12:27:18 PDT
Comment on attachment 560448 [details] [diff] [review]
patch from work time

Nick, can you just fix up our 80 column violations before checking it in?
Comment 3 User image OFFLINE UNTIL 27 FEB 2017 Nicholas Hurley [:nwgh][:hurley] (also hurley@todesschaf.org) 2011-09-16 13:12:21 PDT
Created attachment 560612 [details] [diff] [review]
Patch update

Fixes line length. Carry forward r+
Comment 4 User image Ed Morley [:emorley] 2011-09-16 16:45:08 PDT
Presuming try goes green, will push to inbound first thing tomorrow :-)
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=329eee3b938e
Comment 6 User image Ed Morley [:emorley] 2011-09-18 12:26:54 PDT
https://hg.mozilla.org/mozilla-central/rev/0b31c67e1423
Comment 7 User image sync-1 2013-05-21 22:25:00 PDT
Comment from Mozilla:test

Note You need to log in before you can comment on or make changes to this bug.