Closed
Bug 686957
Opened 13 years ago
Closed 13 years ago
Final video frame is not displayed when seeking to end
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: kinetik, Assigned: cajbir)
References
()
Details
Attachments
(2 files)
|
1.98 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
|
312.43 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
Open testcase. Click "jump to 6 seconds". Tab into the video. Hit "end". The currentTime is reported correctly, but the displayed frame (and frame grabbed by canvas) are still at 6 seconds.
|
||
Updated•13 years ago
|
Component: Spelling checker → Video/Audio
QA Contact: spelling-checker → video.audio
|
Assignee | |
Comment 1•13 years ago
|
||
When decoding to target, ensure last frame is kept when we hit eof so it can be displayed.
|
Reporter | |
Updated•13 years ago
|
Attachment #562654 -
Flags: review?(kinetik) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Test implemented as a reftest. It compares a seek to the end vs a play to the end.
Attachment #563314 -
Flags: review?(kinetik)
|
|
Reporter | |
Comment 3•13 years ago
|
||
Comment on attachment 563314 [details] [diff] [review]
Test
Review of attachment 563314 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/reftests/webm-video/bug686957-ref.html
@@ +3,5 @@
> +<body style="background:white;">
> +<!-- Test that if we seek to the end of a video we get the last frame displayed -->
> +<video src="frames.webm"
> + preload="auto"
> + autoplay
I'm slightly concerned that autoplay could cause the video to play to the end before the loadedmetadata handler had run, causing two ended events, of which the first would run immediately after seeking back 1 second. The test should be more reliable if play() is called in the loadedmetadata handler after the seek request, I think.
Attachment #563314 -
Flags: review?(kinetik) → review+
|
||
Comment 4•13 years ago
|
||
Comment on attachment 563314 [details] [diff] [review]
Test
Review of attachment 563314 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/reftests/webm-video/bug686957-ref.html
@@ +1,5 @@
> +<!DOCTYPE HTML>
> +<html class="reftest-wait">
> +<body style="background:white;">
> +<!-- Test that if we seek to the end of a video we get the last frame displayed -->
> +<video src="frames.webm"
Does frames.webm contain only keyframes? If skip-to-keyframe kicked in, we could end up dropping frames, causing the test to fail?
|
|
Assignee | |
Comment 5•13 years ago
|
||
(In reply to Chris Pearce (:cpearce) (Mozilla Corporation) from comment #4)
> Does frames.webm contain only keyframes? If skip-to-keyframe kicked in, we
> could end up dropping frames, causing the test to fail?
We should still show the last frame even if skip-to-keyframe happens shouldn't we? It seems to me the last frame should be shown always if we hit the end of the video via playback.
|
|
Assignee | |
Comment 6•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bbcc8bb5833
https://hg.mozilla.org/integration/mozilla-inbound/rev/532c01d1ca0e
Flags: in-testsuite+
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla10
|
||
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6bbcc8bb5833
https://hg.mozilla.org/mozilla-central/rev/532c01d1ca0e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•