686963 - Setting the work time using the Bug.update WebService method requires a comment

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Frédéric Buclin]

Since Bugzilla 4.0 (bug 271913), a comment is no longer required when setting the work time. This is working fine from the web UI for 4.0 and 4.2, and is also working fine from the WebService API in 4.0, but this is no longer working in 4.2. If you don't specify a comment at the same time as you specify work_time, you get the following error:

  The function Bugzilla::Comment->create requires a thetext argument, and that argument was not set.


I'm pretty sure this is a regression due to bug 590334.

Comment 1

[Tiago Mello [:timello]]

Attachment: v1

Ok, this patch fixes 2 problems because there were related:

1. Comments with white-spaces where allowed to be added because we were running the validators after the code actually we skip blank comments;

2. $params->{thetext} should not be undefined, otherwise _check_thetext() validator will complain.

Comment 2

[Frédéric Buclin]

Comment on attachment 567888 [details] [diff] [review]
v1

>+    $params->{'thetext'} = $comment || '';

As '0' is a valid comment, you must replace the line above by:

  $params->{'thetext'} = defined($comment) ? $comment : '';


r=LpSolit with this change.

Comment 3

[Frédéric Buclin]

Do not forget the fix on checkin.

Comment 4

[Tiago Mello [:timello]]

(In reply to Frédéric Buclin from comment #2)
> Comment on attachment 567888 [details] [diff] [review] [diff] [details] [review]
> v1
> 
> >+    $params->{'thetext'} = $comment || '';
> 
> As '0' is a valid comment, you must replace the line above by:
> 
>   $params->{'thetext'} = defined($comment) ? $comment : '';

Indeed! Thanks!

Comment 5

[Tiago Mello [:timello]]

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/                                                                                                             
modified Bugzilla/Bug.pm
Committed revision 7948.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/                                                                                                           
modified Bugzilla/Bug.pm
Committed revision 7986.

Comment 6

[Max Kanat-Alexander]

Comment on attachment 567888 [details] [diff] [review]
v1

Review of attachment 567888 [details] [diff] [review]:
-----------------------------------------------------------------

::: Bugzilla/Bug.pm
@@ +2674,3 @@
>      # Fill out info that doesn't change and callers may not pass in
>      $params->{'bug_id'}  = $self;
> +    $params->{'thetext'} = $comment || '';

"0" is a valid comment.