Closed Bug 686973 Opened 14 years ago Closed 14 years ago

Socorro - make Java signatures for Fennec

Categories

(Socorro :: General, task)

Product:
Socorro
Component:
General
Platform:
x86
Linux
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: lars, Assigned: lars)

Details

It is possible to get Java signature information from the 'app_notes' field in the processed json and reports table, iff "libmozutils.so" / "Java_org_mozilla_gecko_GeckoAppShell_reportJavaCrash" appears within the crashing stack frame. Rework signature generation to create overall signatures using the 'app_notes' data when appropriate. On this sample crash (https://crash-stats.mozilla.com/report/index/7df304c2-2d35-4f15-91ea-1b3a32110809), what would you want the signature to look like? crash signatures are generated by combining/ignoring frame signatures using a set of "skip list rules". Would there need to be a similar system for Java crashes?
It would probably be nice to move this data to its own custom field instead of abusing the general-purpose "App Notes" field for it.
regardless of the source field of the java data, getting answers to my questions in comment #0 is key to getting this on the schedule for inclusion in a future version of Socorro. Anyone care to take a stab at getting me some answers?
Assigning to nhirata, he ought to be able to answer and then punt back to lars.
Assignee: nobody → nhirata.bugzilla
(In reply to K Lars Lohn [:lars] [:klohn] from comment #2) > regardless of the source field of the java data, getting answers to my > questions in comment #0 is key to getting this on the schedule for inclusion > in a future version of Socorro. Anyone care to take a stab at getting me > some answers? so, if I understand you correctly the question is can the java stacks be in some other format. The answer is "sure", within reason. I'd suggest filing a separate bug with a specification what you want the format to be. If I've misunderstood your question, let me know.
nhirata: lars : bug 686973, can we do something like the first line in the java app notes? java.lang.RuntimeException: Unable to pause activity {org.mozilla.fennec/org.mozilla.fennec.App}: java.lang.IllegalArgumentException: Receiver not registered: [10:03am] firebot: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=686973 nor, --, ---, nhirata.bugzilla, NEW, Socorro - make Java signatures for Fennec [10:04am] nhirata: if it has to be from the signature list I would guess : Java_org_mozilla_gecko_GeckoAppShell_reportJavaCrash [10:04am] nhirata: the problem with that is that any java crash would be seen as that. [10:06am] lars: signatures are up to 255 characters long. I can parse the AppNotes to extract what you think is relevant. Then I can take what I parse and create a signature. It's totally up to you guys to tell me how to parse that data. [10:07am] nhirata: ok so more of the limitation is the character string being 255... [10:08am] lars: the idea is to boil the AppNotes down to something that will fit in 255 characters. [10:08am] nhirata: gotcha. [10:09am] nhirata: how about the first line before the {? java.lang.RuntimeException: Unable to pause activity [10:09am] nhirata: ie : java.lang.RuntimeException: Unable to pause activity Would this be ok, blassey? Or do you have a different idea?
lars: in crash 7df304c2-2d35-4f15-91ea-1b3a32110809, there is no line before "java.lang.RuntimeException: Unable to pause activity", do you mean after? [10:12am] firebot: lars: http://crash-stats.mozilla.com/report/index/7df304c2-2d35-4f15-91ea-1b3a32110809 [10:12am] nhirata: The first line is : java.lang.RuntimeException: Unable to pause activity {org.mozilla.fennec/org.mozilla.fennec.App}: java.lang.IllegalArgumentException: Receiver not registered: [10:12am] nhirata: I was thinking part of the first line : java.lang.RuntimeException: Unable to pause activity [10:14am] lars: so, just the first line up to the first open { [10:15am] lars: I need to know what triggers the processor to look to the AppNotes: just the presence of any text in that field? Is the regular signature to be completely ignored? [10:16am] nhirata: Java_org_mozilla_gecko_GeckoAppShell_reportJavaCrash signature within the top 10 ~ 15 signatures [10:17am] lars: ok [10:17am] nhirata: yes, the regular signature is to be ignored for the report, because it's a Java crash
Spec : - Limitation is the 255 for the signature - looking at the app notes is triggered by Java_org_mozilla_gecko_GeckoAppShell_reportJavaCrash within the first 15 signature - we want to ignore the regular signature and look at the app notes - First line in the app notes for the java crash is : java.lang.RuntimeException: Unable to pause activity {org.mozilla.fennec/org.mozilla.fennec.App}: java.lang.IllegalArgumentException: Receiver not registered: - we want to have everything up to the first open { End result should be : java.lang.RuntimeException: Unable to pause activity
(In reply to Naoki Hirata :nhirata from comment #7) > Spec : > - Limitation is the 255 for the signature 255 lines? sure 255 chars? not very useful
255 chars have been enough for the vast majority of signatures for quite some time now. Also, they are used in headers and whatnot, having them be significantly longer would not be good there. We found how to make a C++ stack signature be mostly useful in 255 chars, I'd hope that would work for Java as well.
This change will be landing on Socorro trunk within a couple days. I'm targeting it for inclusion in version 2.3.2.
Assignee: nhirata.bugzilla → lars
Target Milestone: --- → 2.3.2
this has been pushed to staging and awaits deployment.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.