Closed Bug 686999 Opened 9 years ago Closed 9 years ago

Rename getBoolPref helper to GetBoolPref and make more use of it

Categories

(SeaMonkey :: General, defect)

defect
Not set
normal

Tracking

(seamonkey2.6 fixed)

RESOLVED FIXED
seamonkey2.6
Tracking Status
seamonkey2.6 --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

Attachments

(1 file)

As suggested by Neil in bug 686386, utilityOverlay's getBoolPref could be renamed to match the style of the other pref helpers in that file.
Additionally there are places in suite/browser and suite/common where more use of GetBoolPref helper could be made.
This patch:
* Renames helper function to GetBoolPref.
* Uses helper in suite/browser and suite/common code.
Attachment #560488 - Flags: review?(neil)
Attachment #560488 - Flags: review?(neil) → review+
Comment on attachment 560488 [details] [diff] [review]
Rename and switch [Checked in: Comment 1]

http://hg.mozilla.org/comm-central/rev/68c36509612b
Attachment #560488 - Attachment description: Rename and switch → Rename and switch [Checked in: Comment 1]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6
So now we have getBoolPref(), GetIntPref(), Get|SetStringPref(), GetLocalizedStringPref(),

You seem to be trying to reinvent the old nsUserSettings.js ;-)
Post from mozillazine forum:
Bug 686999 breakes SmartSearch in SeaMonkey 2.6, so smartsearch.js needs a patch to get it working again.
Line 379:
- var loadInBackground = getBoolPref("browser.tabs.loadBookmarksInBackground", false);
+ var loadInBackground = GetBoolPref("browser.tabs.loadBookmarksInBackground", false);
(In reply to Phoenix from comment #3)
> Post from mozillazine forum:
> Bug 686999 breakes SmartSearch in SeaMonkey 2.6, so smartsearch.js needs a
> patch to get it working again.
> Line 379:
> - var loadInBackground =
> getBoolPref("browser.tabs.loadBookmarksInBackground", false);
> + var loadInBackground =
> GetBoolPref("browser.tabs.loadBookmarksInBackground", false);

This is the SmartSearch add-on, has this been flagged with the author?
Whoops, I thought that report about some Seamonkey internal stuff (was sleepy), e-mailed to add-on author :)
You need to log in before you can comment on or make changes to this bug.