686999 - Rename getBoolPref helper to GetBoolPref and make more use of it

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

Attachment: Rename and switch [Checked in: Comment 1]

As suggested by Neil in bug 686386, utilityOverlay's getBoolPref could be renamed to match the style of the other pref helpers in that file.
Additionally there are places in suite/browser and suite/common where more use of GetBoolPref helper could be made.
This patch:
* Renames helper function to GetBoolPref.
* Uses helper in suite/browser and suite/common code.

Comment 1

[Ian Neal]

Comment on attachment 560488 [details] [diff] [review]
Rename and switch [Checked in: Comment 1]

http://hg.mozilla.org/comm-central/rev/68c36509612b

Comment 2

[Philip Chee]

So now we have getBoolPref(), GetIntPref(), Get|SetStringPref(), GetLocalizedStringPref(),

You seem to be trying to reinvent the old nsUserSettings.js ;-)

Comment 3

[Phoenix]

Post from mozillazine forum:
Bug 686999 breakes SmartSearch in SeaMonkey 2.6, so smartsearch.js needs a patch to get it working again.
Line 379:
- var loadInBackground = getBoolPref("browser.tabs.loadBookmarksInBackground", false);
+ var loadInBackground = GetBoolPref("browser.tabs.loadBookmarksInBackground", false);

Comment 4

[Ian Neal]

(In reply to Phoenix from comment #3)
> Post from mozillazine forum:
> Bug 686999 breakes SmartSearch in SeaMonkey 2.6, so smartsearch.js needs a
> patch to get it working again.
> Line 379:
> - var loadInBackground =
> getBoolPref("browser.tabs.loadBookmarksInBackground", false);
> + var loadInBackground =
> GetBoolPref("browser.tabs.loadBookmarksInBackground", false);

This is the SmartSearch add-on, has this been flagged with the author?

Comment 5

[Phoenix]

Whoops, I thought that report about some Seamonkey internal stuff (was sleepy), e-mailed to add-on author :)