687007 - Refactor all code that uses nsIChannel.contentDispositionHeader

Status: NEW

(Core :: Networking, defect, P5)

Description

[Jason Duell]

We still have code that uses the full, raw content-disposition header, either via nsIChannel.contentDispositionHeader, or by just using getHeader().  These should all be refactored to use the 'contentDisposition' and 'contentDispositionFilename' properties.

I'm seeing stuff like the full disposition header being stuffed into imageCache entry properties and then fished out in contentAreaUtils.js.  It's also in nsIDOMWindowUtils and then retrieved here:

    http://mxr.mozilla.org/mozilla-central/source/toolkit/content/contentAreaUtils.js#158
    http://mxr.mozilla.org/mozilla-central/source/toolkit/content/contentAreaUtils.js#182

The context menu popupstate contains full C-D header too:

    http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/ContextCommands.js#62

Death to raw C-D header parsing!

I'm fine with this work being chopped into separate bugs as needed.

Comment 1

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258