687143 - Expose reasons for changing builder visibility (give getBuilderHistory.php a UI)

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

When you Save Changes on hiding/unhiding builders in the admin panel there's space to leave a reason for the changes. AFAICT that information isn't visible anywhere, but would be pretty helpful if you're trying to work out why something is hidden.

Comment 1

[Phil Ringnalda (:philor)]

You call https://tbpl.mozilla.org/php/getBuilderHistory.php?name=mozilla-central-win64 not visible? What, you want actual _UI_? ;)

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Shockingly unreasonable of me, but yeah. :-)

Comment 3

[Ed Morley [:emorley]]

Clarifying summary since was going to file this and only spotted this by coincidence.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 5

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

Fixed a one-character typo.

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 747026 [details] [diff] [review]
patch v2

Review of attachment 747026 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for doing this! I was only thinking today that a UI would make the investigations in bug 784681 much easier.

Looks good - I have a few style change suggestions, happy for you to take as many or few of them as you wish :-) Diff at:
http://www.pastebin.mozilla.org/2385985

Comment 7

[Ed Morley [:emorley]]

I should add that the margin-left changes are primarily to improve legibility in the "select multiple buildernames to view the history of" case.

Comment 8

[Matt Brubeck (:mbrubeck)]

Pushed with Ed's style tweaks (thanks!):
https://hg.mozilla.org/webtools/tbpl/rev/2a0f5505a67a

Comment 9

[Ed Morley [:emorley]]

In production as of 2013-05-09.