Closed Bug 687143 Opened 10 years ago Closed 9 years ago

Expose reasons for changing builder visibility (give getBuilderHistory.php a UI)

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Assigned: mbrubeck)

References

Details

Attachments

(1 file, 1 obsolete file)

When you Save Changes on hiding/unhiding builders in the admin panel there's space to leave a reason for the changes. AFAICT that information isn't visible anywhere, but would be pretty helpful if you're trying to work out why something is hidden.
Shockingly unreasonable of me, but yeah. :-)
Clarifying summary since was going to file this and only spotted this by coincidence.
Summary: Expose reasons for changing builder visibility → Expose reasons for changing builder visibility (give getBuilderHistory.php a UI)
Hardware: x86 → All
Version: 2.0 → Trunk
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #747007 - Flags: review?(emorley)
Attached patch patch v2Splinter Review
Fixed a one-character typo.
Attachment #747007 - Attachment is obsolete: true
Attachment #747007 - Flags: review?(emorley)
Attachment #747026 - Flags: review?(emorley)
Comment on attachment 747026 [details] [diff] [review]
patch v2

Review of attachment 747026 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for doing this! I was only thinking today that a UI would make the investigations in bug 784681 much easier.

Looks good - I have a few style change suggestions, happy for you to take as many or few of them as you wish :-) Diff at:
http://www.pastebin.mozilla.org/2385985
Attachment #747026 - Flags: review?(emorley) → review+
I should add that the margin-left changes are primarily to improve legibility in the "select multiple buildernames to view the history of" case.
Pushed with Ed's style tweaks (thanks!):
https://hg.mozilla.org/webtools/tbpl/rev/2a0f5505a67a
Depends on: 870334
In production as of 2013-05-09.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.