687166 - GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable 'current' set but not used [-Wunused-but-set-variable]"

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Nathan Froyd [:froydnj]]

The `current' variable in nsSplitterFrameInner::SetPreferredSize is set but unused.  Patch coming up.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: remove set-but-unused variable current

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 560633 [details] [diff] [review]
remove set-but-unused variable current

Could you remove also 
//printf("current=%d, pref=%d", current/onePixel, pref/onePixel);

Comment 3

[Atul Aggarwal]

Attachment: Rebase with the bool change

Comment 4

[Takanori MATSUURA]

(In reply to Atul Aggarwal from comment #3)
I suppose you'd like to carry over review+.

Comment 5

[Nathan Froyd [:froydnj]]

Attachment: GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]".

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 565210 [details] [diff] [review]
GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]".

Rebased patch with smaug's requested change.  Carrying over initial r+.

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 564030 [details] [diff] [review]
Rebase with the bool change

Marking previous rebased patch as obsolete.

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 565210 [details] [diff] [review]
GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]".

Whoops, I'm not the reviewer here.

Comment 9

[Ed Morley [:emorley]]

In my queue, which is heading to try first then inbound :-)
https://tbpl.mozilla.org/?tree=Try&rev=a8fbb2a76633

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7b86824694a

Comment 11

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/d7b86824694a