Last Comment Bug 687166 - GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable 'current' set but not used [-Wunused-but-set-variable]"
: GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning:...
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Nathan Froyd [:froydnj]
:
Mentors:
Depends on:
Blocks: buildwarning
  Show dependency treegraph
 
Reported: 2011-09-16 14:56 PDT by Nathan Froyd [:froydnj]
Modified: 2011-10-07 12:37 PDT (History)
4 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
remove set-but-unused variable current (892 bytes, patch)
2011-09-16 14:59 PDT, Nathan Froyd [:froydnj]
bugs: review+
Details | Diff | Splinter Review
Rebase with the bool change (890 bytes, patch)
2011-10-02 02:01 PDT, Atul Aggarwal
no flags Details | Diff | Splinter Review
GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]". (1.19 KB, patch)
2011-10-06 07:06 PDT, Nathan Froyd [:froydnj]
nfroyd: review+
Details | Diff | Splinter Review

Description Nathan Froyd [:froydnj] 2011-09-16 14:56:24 PDT
The `current' variable in nsSplitterFrameInner::SetPreferredSize is set but unused.  Patch coming up.
Comment 1 Nathan Froyd [:froydnj] 2011-09-16 14:59:08 PDT
Created attachment 560633 [details] [diff] [review]
remove set-but-unused variable current
Comment 2 Olli Pettay [:smaug] (vacation Aug 25-28) 2011-09-16 16:38:55 PDT
Comment on attachment 560633 [details] [diff] [review]
remove set-but-unused variable current

Could you remove also 
//printf("current=%d, pref=%d", current/onePixel, pref/onePixel);
Comment 3 Atul Aggarwal 2011-10-02 02:01:33 PDT
Created attachment 564030 [details] [diff] [review]
Rebase with the bool change
Comment 4 Takanori MATSUURA 2011-10-03 20:21:46 PDT
(In reply to Atul Aggarwal from comment #3)
I suppose you'd like to carry over review+.
Comment 5 Nathan Froyd [:froydnj] 2011-10-06 07:06:29 PDT
Created attachment 565210 [details] [diff] [review]
GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]".
Comment 6 Nathan Froyd [:froydnj] 2011-10-06 07:08:07 PDT
Comment on attachment 565210 [details] [diff] [review]
GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]".

Rebased patch with smaug's requested change.  Carrying over initial r+.
Comment 7 Nathan Froyd [:froydnj] 2011-10-06 07:08:45 PDT
Comment on attachment 564030 [details] [diff] [review]
Rebase with the bool change

Marking previous rebased patch as obsolete.
Comment 8 Nathan Froyd [:froydnj] 2011-10-06 07:09:45 PDT
Comment on attachment 565210 [details] [diff] [review]
GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]".

Whoops, I'm not the reviewer here.
Comment 9 Ed Morley [:emorley] 2011-10-07 03:30:39 PDT
In my queue, which is heading to try first then inbound :-)
https://tbpl.mozilla.org/?tree=Try&rev=a8fbb2a76633
Comment 11 Matt Brubeck (:mbrubeck) 2011-10-07 12:37:43 PDT
https://hg.mozilla.org/mozilla-central/rev/d7b86824694a

Note You need to log in before you can comment on or make changes to this bug.