The default bug view has changed. See this FAQ.

GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable 'current' set but not used [-Wunused-but-set-variable]"

RESOLVED FIXED in mozilla10

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Blocks: 1 bug)

Trunk
mozilla10
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
The `current' variable in nsSplitterFrameInner::SetPreferredSize is set but unused.  Patch coming up.
(Assignee)

Comment 1

6 years ago
Created attachment 560633 [details] [diff] [review]
remove set-but-unused variable current
Assignee: nobody → nfroyd
Attachment #560633 - Flags: review?(Olli.Pettay)
Comment on attachment 560633 [details] [diff] [review]
remove set-but-unused variable current

Could you remove also 
//printf("current=%d, pref=%d", current/onePixel, pref/onePixel);
Attachment #560633 - Flags: review?(Olli.Pettay) → review+

Updated

6 years ago
Blocks: 187528

Updated

6 years ago
Whiteboard: [build_warning]

Updated

6 years ago
Keywords: checkin-needed

Comment 3

6 years ago
Created attachment 564030 [details] [diff] [review]
Rebase with the bool change
Attachment #560633 - Attachment is obsolete: true

Comment 4

6 years ago
(In reply to Atul Aggarwal from comment #3)
I suppose you'd like to carry over review+.
(Assignee)

Comment 5

6 years ago
Created attachment 565210 [details] [diff] [review]
GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]".
(Assignee)

Comment 6

6 years ago
Comment on attachment 565210 [details] [diff] [review]
GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]".

Rebased patch with smaug's requested change.  Carrying over initial r+.
Attachment #565210 - Flags: review+
(Assignee)

Comment 7

6 years ago
Comment on attachment 564030 [details] [diff] [review]
Rebase with the bool change

Marking previous rebased patch as obsolete.
Attachment #564030 - Attachment is obsolete: true
(Assignee)

Comment 8

6 years ago
Comment on attachment 565210 [details] [diff] [review]
GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]".

Whoops, I'm not the reviewer here.
In my queue, which is heading to try first then inbound :-)
https://tbpl.mozilla.org/?tree=Try&rev=a8fbb2a76633
Keywords: checkin-needed
OS: Linux → All
Hardware: x86 → All
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7b86824694a
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla10
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/d7b86824694a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.