687208 - Tree closure hook for Jaegermonkey

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Brian Hackett [Laid off!]]

I get this while trying to push to JM.

pushing to ssh://[e-mail]@hg.mozilla.org/projects/jaegermonkey
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: Unrecognized tree!  I don't know how to check closed status for jaegermonkey.
remote: transaction abort!
remote: rollback completed
remote: abort: pretxnchangegroup.a_treeclosure hook failed
abort: unexpected response: empty string

Why isn't the default to allow pushes on unrecognized trees?  This is slowing me down.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

I can't find any bugs asking for the hook to be added, there's no tree status html in http://tinderbox.mozilla.org/Jaegermonkey/status.html, and no jaegermonkey entry in http://hg.mozilla.org/hgcustom/hghooks/file/ebea31cf1cc0/mozhghooks/treeclosure.py#l23.

--> Over to IT to remove the hook from hg.mozilla.org/projects/jaegermonkey

Comment 2

[Justin Wood (:Callek)]

(In reply to Brian Hackett from comment #0)
> Why isn't the default to allow pushes on unrecognized trees?  This is
> slowing me down.

Interesting, it *used* to fail open on unrecognized trees. At least as far as I can recall. I know the comm* closure hook does fail-open.

Comment 3

[Brian Hackett [Laid off!]]

Can someone fix this ASAP?  This is blocking me from being able to push to JM.

Comment 4

[Corey Shields [:cshields]]

This hook was added per bug 664493

I've removed the hooks from jaegermonkey.  Please reopen if you still run into issues.