687240 - Remove unnecessary scrollButtonUp element declaration in Endurance test testTabbedBrowsing_PinAndUnpinAppTab

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Shriram (irc: Mavericks)]

Attachment: Patch

User Agent: Mozilla/5.0 (Windows NT 6.0; rv:6.0.2) Gecko/20100101 Firefox/6.0.2
Build ID: 20110902133214

Steps to reproduce:

Removed a line of code

Comment 1

[u279076]

What is the purpose of this patch? Why is the line needed to be removed? Why is the patch not submitted to bug 670721?

Sorry, I'm not saying what you are doing is wrong. I'm just a bit confused because it's not our normal process. Thanks.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Because bug 670721 has been already fixed. There is no need to reopen it.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 560695 [details] [diff] [review]
Patch

Thanks for spotting this Shriram. I updated the commit message to reflect the correct bug number and summary. Please make sure this is accurate when submitting patches in the future.

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/5773ec803008 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/5acbd1078d10 (mozilla-aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/044348dbc036 (mozilla-beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/777adf25ee31 (mozilla-release)
http://hg.mozilla.org/qa/mozmill-tests/rev/c0c7bcfa0c02 (mozilla-2.0)

Comment 4

[Shriram (irc: Mavericks)]

(In reply to Dave Hunt (:davehunt) from comment #3)
> Comment on attachment 560695 [details] [diff] [review] Patch
> I updated the commit message to reflect
> the correct bug number and summary. Please make sure this is accurate when
> submitting patches in the future.

Thanks Dave. I shall keep it in mind.