687247 - Bugzilla crashes when creating a new flagtype on PostgreSQL

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Frédéric Buclin]

Due to the refactoring in bug 523205, creating a new flagtype on PostgreSQL crashes with:

DBD::Pg::db do failed: ERROR:  value too long for type character(1) [for Statement "INSERT INTO flagtypes (grant_group_id, request_group_id, sortkey, name, description, cc_list, is_requestable, is_multiplicable, is_requesteeble, is_active, target_type) VALUES (?,?,?,?,?,?,?,?,?,?,?)"] at Bugzilla/Object.pm line 552
	Bugzilla::Object::insert_create_data('Bugzilla::FlagType', 'HASH(0x8c1b1e0)') called at Bugzilla/FlagType.pm line 128
	Bugzilla::FlagType::create('Bugzilla::FlagType', 'HASH(0x95e59d8)') called at /var/www/html/bugzilla_qa42/editflagtypes.cgi line 291


The reason is that target_type returns 'bug' or 'attachment' while the DB expects to get a single character 'b' or 'a'. MySQL doesn't crash, because it inserts as much data as possible, i.e. the first character. PostgreSQL just rejects a too long string and fails.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

r=me as module owner.

Comment 2

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/FlagType.pm
Committed revision 7962.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified Bugzilla/FlagType.pm
Committed revision 7930.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 560796 [details] [diff] [review]
patch, v1

Review of attachment 560796 [details] [diff] [review]:
-----------------------------------------------------------------

::: Bugzilla/FlagType.pm
@@ +118,5 @@
>  
>      $class->check_required_create_fields(@_);
>      my $params = $class->run_create_validators(@_);
> +    # In the DB, only the first character of the target type is stored.
> +    $params->{target_type} = substr($params->{target_type}, 0, 1);

FWIW, the validator should be doing that.