687318 - Allow createProcessingInstruction in HTML

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Anne (:annevk)]

You can already adopt a processing instruction from one tree to another. You should be able to create them anywhere too for simplicity.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1.1

And some test fixes.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1.2

And now without unrelated hunks.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 560869 [details] [diff] [review]
Patch v1.2

Can you get another DOM peer to review this?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 560869 [details] [diff] [review]
Patch v1.2


>+    if (!aShouldSucceed) {
>+      ok(0, "Invalid processing instruction creation", aReason);
ok(false, ....)

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

That's copied from test_bug352728.*x*html, want me to change it there too?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

No need.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/8d53336eb076

Comment 9

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en/DOM/document.createProcessingInstruction

And mentioned on Firefox 10 for developers.