Last Comment Bug 687318 - Allow createProcessingInstruction in HTML
: Allow createProcessingInstruction in HTML
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
http://dvcs.w3.org/hg/domcore/raw-fil...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-18 01:06 PDT by Anne (:annevk)
Modified: 2011-12-14 09:07 PST (History)
6 users (show)
Ms2ger: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (14.56 KB, patch)
2011-09-18 01:57 PDT, :Ms2ger (⌚ UTC+1/+2)
no flags Details | Diff | Splinter Review
Patch v1.1 (16.45 KB, patch)
2011-09-18 06:57 PDT, :Ms2ger (⌚ UTC+1/+2)
no flags Details | Diff | Splinter Review
Patch v1.2 (4.61 KB, patch)
2011-09-19 03:41 PDT, :Ms2ger (⌚ UTC+1/+2)
bugs: review+
Details | Diff | Splinter Review

Description Anne (:annevk) 2011-09-18 01:06:09 PDT
You can already adopt a processing instruction from one tree to another. You should be able to create them anywhere too for simplicity.
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2011-09-18 01:57:24 PDT
Created attachment 560767 [details] [diff] [review]
Patch v1
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-09-18 06:57:43 PDT
Created attachment 560787 [details] [diff] [review]
Patch v1.1

And some test fixes.
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2011-09-19 03:41:06 PDT
Created attachment 560869 [details] [diff] [review]
Patch v1.2

And now without unrelated hunks.
Comment 4 Jonas Sicking (:sicking) PTO Until July 5th 2011-09-19 12:40:35 PDT
Comment on attachment 560869 [details] [diff] [review]
Patch v1.2

Can you get another DOM peer to review this?
Comment 5 Olli Pettay [:smaug] 2011-09-19 22:15:12 PDT
Comment on attachment 560869 [details] [diff] [review]
Patch v1.2


>+    if (!aShouldSucceed) {
>+      ok(0, "Invalid processing instruction creation", aReason);
ok(false, ....)
Comment 6 :Ms2ger (⌚ UTC+1/+2) 2011-09-20 01:11:23 PDT
That's copied from test_bug352728.*x*html, want me to change it there too?
Comment 7 Olli Pettay [:smaug] 2011-09-20 01:45:40 PDT
No need.
Comment 8 :Ms2ger (⌚ UTC+1/+2) 2011-10-02 07:17:15 PDT
https://hg.mozilla.org/mozilla-central/rev/8d53336eb076
Comment 9 Eric Shepherd [:sheppy] 2011-12-14 09:07:22 PST
Documentation updated:

https://developer.mozilla.org/en/DOM/document.createProcessingInstruction

And mentioned on Firefox 10 for developers.

Note You need to log in before you can comment on or make changes to this bug.