Allow createProcessingInstruction in HTML

RESOLVED FIXED in mozilla10

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: annevk, Assigned: Ms2ger)

Tracking

({dev-doc-complete})

Trunk
mozilla10
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
You can already adopt a processing instruction from one tree to another. You should be able to create them anywhere too for simplicity.
(Assignee)

Comment 1

6 years ago
Created attachment 560767 [details] [diff] [review]
Patch v1
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #560767 - Flags: review?(jonas)
(Assignee)

Comment 2

6 years ago
Created attachment 560787 [details] [diff] [review]
Patch v1.1

And some test fixes.
Attachment #560767 - Attachment is obsolete: true
Attachment #560767 - Flags: review?(jonas)
Attachment #560787 - Flags: review?(jonas)
(Assignee)

Comment 3

6 years ago
Created attachment 560869 [details] [diff] [review]
Patch v1.2

And now without unrelated hunks.
Attachment #560787 - Attachment is obsolete: true
Attachment #560787 - Flags: review?(jonas)
Attachment #560869 - Flags: review?(jonas)
Comment on attachment 560869 [details] [diff] [review]
Patch v1.2

Can you get another DOM peer to review this?
Attachment #560869 - Flags: review?(jonas) → review?

Comment 5

6 years ago
Comment on attachment 560869 [details] [diff] [review]
Patch v1.2


>+    if (!aShouldSucceed) {
>+      ok(0, "Invalid processing instruction creation", aReason);
ok(false, ....)
Attachment #560869 - Flags: review? → review+
(Assignee)

Comment 6

6 years ago
That's copied from test_bug352728.*x*html, want me to change it there too?

Comment 7

6 years ago
No need.

Updated

6 years ago
Keywords: dev-doc-needed
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/8d53336eb076
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Version: unspecified → Trunk
Documentation updated:

https://developer.mozilla.org/en/DOM/document.createProcessingInstruction

And mentioned on Firefox 10 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.