Last Comment Bug 687342 - arm.obj : warning LNK4221: This object file does not define any previously undefined public symbols
: arm.obj : warning LNK4221: This object file does not define any previously un...
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: mozilla9
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on:
Blocks: buildwarning
  Show dependency treegraph
 
Reported: 2011-09-18 07:06 PDT by Ed Morley [:emorley]
Modified: 2011-09-20 07:48 PDT (History)
3 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.00 KB, patch)
2011-09-18 08:20 PDT, Ed Morley [:emorley]
no flags Details | Diff | Review
Patch v1.1 (1.00 KB, patch)
2011-09-18 09:06 PDT, Ed Morley [:emorley]
khuey: review+
Details | Diff | Review

Description Ed Morley [:emorley] 2011-09-18 07:06:14 PDT
MSVC 2010 using http://hg.mozilla.org/integration/mozilla-inbound/rev/f827e9173fea

{
arm.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library
}

File in question:
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/arm.cpp

Included here:
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/objs.mk#72

Only actually does anything #if defined(MOZILLA_ARM_HAVE_CPUID_DETECTION), which is set here:
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/arm.h#110
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/arm.h#115

ie:
if defined(__linux__) || defined(ANDROID) || (defined(_MSC_VER) && defined(_M_ARM))
Comment 1 Ed Morley [:emorley] 2011-09-18 08:20:34 PDT
Created attachment 560793 [details] [diff] [review]
Patch v1

Adds a |ifeq (arm, $(TARGET_CPU))| around the arm.cpp line.

Builds fine locally with MSVC 2010 and the LNK4221 warning in comment 0 no longer appears. 

Sent to try:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=2f7ee79fc650
Comment 2 Ed Morley [:emorley] 2011-09-18 09:06:54 PDT
Created attachment 560794 [details] [diff] [review]
Patch v1.1

As before, except this time with += rather than =+ (doh!).

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=2058bc9b70b2
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13) 2011-09-19 15:28:52 PDT
Comment on attachment 560794 [details] [diff] [review]
Patch v1.1

>diff --git a/xpcom/glue/objs.mk b/xpcom/glue/objs.mk
>+ifeq (arm, $(TARGET_CPU))

Nit:

ifeq (arm,$(TARGET_CPU))
Comment 5 :Ehsan Akhgari (busy, don't ask for review please) 2011-09-20 07:48:37 PDT
https://hg.mozilla.org/mozilla-central/rev/abfc871cc026

Note You need to log in before you can comment on or make changes to this bug.