687342 - arm.obj : warning LNK4221: This object file does not define any previously undefined public symbols

Status: RESOLVED FIXED

Description

[Ed Morley [:emorley]]

MSVC 2010 using http://hg.mozilla.org/integration/mozilla-inbound/rev/f827e9173fea

{
arm.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library
}

File in question:
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/arm.cpp

Included here:
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/objs.mk#72

Only actually does anything #if defined(MOZILLA_ARM_HAVE_CPUID_DETECTION), which is set here:
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/arm.h#110
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/arm.h#115

ie:
if defined(__linux__) || defined(ANDROID) || (defined(_MSC_VER) && defined(_M_ARM))

Comment 1

[Ed Morley [:emorley]]

Created attachment 560793 [details] [diff] [review]
Patch v1

Adds a |ifeq (arm, $(TARGET_CPU))| around the arm.cpp line.

Builds fine locally with MSVC 2010 and the LNK4221 warning in comment 0 no longer appears. 

Sent to try:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=2f7ee79fc650

Comment 2

[Ed Morley [:emorley]]

Created attachment 560794 [details] [diff] [review]
Patch v1.1

As before, except this time with += rather than =+ (doh!).

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=2058bc9b70b2

Comment 3

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Comment on attachment 560794 [details] [diff] [review]
Patch v1.1

>diff --git a/xpcom/glue/objs.mk b/xpcom/glue/objs.mk
>+ifeq (arm, $(TARGET_CPU))

Nit:

ifeq (arm,$(TARGET_CPU))

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/abfc871cc026

Comment 5

[:Ehsan Akhgari (needinfo please, extremely long backlog, Away 8/18)]

https://hg.mozilla.org/mozilla-central/rev/abfc871cc026