687450 - Add back-end method to enable and disable add-ons

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Alex Lakatos[:AlexLakatos]]

Add an enablePlugin() method to addons.js that uses back-end code and does not use the UI. 

Needed for the teardownModule in bug 674221.

Comment 1

[Alex Lakatos[:AlexLakatos]]

Attachment: patch v1.0

Added enablePlugin that uses the AddonManager component and can be called from outside the AddonsManager tab.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 560935 [details] [diff] [review]
patch v1.0

Methods in APIs should be able to be used more widely. So it's not only about plugins but all add-ons. Further you probably also want to disable add-ons via the backend. All that should be taken care in this helper method. Also this method is working asynchronously, so we need a way of synching.

Comment 3

[Alex Lakatos[:AlexLakatos]]

Henrik, Anthony, do you guys have any tips for synching this? Should I use some sort of waitFor?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Use a local variable inside the method which is set to false at the beginning. Once the plugin callback has been executed set it to true from inside the callback. Now a waitFor call has to take place to wait for completion.

Comment 5

[Remus Pop (:RemusPop)]

Attachment: patch v2

The method has synchronisation now and has been renamed.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We should not only have a method for enabling an add-on but also for disabling it.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 564794 [details] [diff] [review]
patch v2

>+function enableAddon(aAddonId) {
>+  addonIsEnabled = false;

You forgot 'var' or 'let' when declaring the variable. If you don't specify that it will become a global variable instead. Also it could be named as 'finished'. It will make it easier when we have mulitple of those helper functions. In that case I wonder if we could have an internal method we could use for synchronization.

>+  mozmill.utils.waitFor(function () {
>+      return addonIsEnabled;
>+    }, "Addon is enabled");
>+}

Please check the indentation and add the addon id to it for better debugging purposes.

Comment 8

[Remus Pop (:RemusPop)]

Attachment: patch v3

Updated and created a disableAddon method.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 566176 [details] [diff] [review]
patch v3

>+  mozmill.utils.waitFor(function () {
>+      return finished;
>+  }, "Addon is enabled - expected ID - " + aAddonId);

nit: please fix the indentation inside the callback. Also the message should say: "Add-on 'XYZ' has been disabled". Keep an eye on disabled and not enabled. Looks like you missed to change it when copying and pasting code.

Same applies to the enableAddon function.

Comment 10

[Remus Pop (:RemusPop)]

Attachment: patch v4

Addressed all issues.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/a71cb755c29b (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/0524c582ebdd (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/5eafb50ab61c (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/eab89a226b5c (release)