do not "git pull" with puppet in socorro-vagrant

RESOLVED FIXED

Status

Socorro
General
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: rhelmer, Assigned: rhelmer)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Right now puppet clones the repo if "~socorro/dev/socorro" does not exist, and does a "git pull" in that directory on each run.

"git pull" returns non-0 if the user has changed the branch, and running puppet is the suggested way to deploy in the README.

We should just not have puppet do the "git pull" and leave that up to the user.
(Assignee)

Comment 1

7 years ago
Created attachment 560953 [details] [diff] [review]
update vagrant submodule to fix error on pull when branch not on master

https://github.com/mozilla/socorro/pull/30
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED
Attachment #560953 - Flags: review?(chris.lonnen)
(Assignee)

Comment 2

7 years ago
Created attachment 560963 [details] [diff] [review]
update vagrant submodule to fix error on pull when branch not on master

Here's the actual change:

https://github.com/rhelmer/socorro-vagrant/commit/185ff632187d46399fae0e932c83c6d65cc18d41

Pull req just for the submodule update:

https://github.com/mozilla/socorro/pull/31
Attachment #560953 - Attachment is obsolete: true
Attachment #560953 - Flags: review?(chris.lonnen)
Attachment #560963 - Flags: review?(chris.lonnen)

Comment 3

7 years ago
Comment on attachment 560953 [details] [diff] [review]
update vagrant submodule to fix error on pull when branch not on master

merged as:
https://github.com/mozilla/socorro/commit/6f1ecf0dcde48860151eb1b246989914def25654
Attachment #560953 - Flags: review+

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Attachment #560963 - Flags: review?(chris.lonnen) → review+
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.