Closed
Bug 687522
Opened 14 years ago
Closed 14 years ago
do not "git pull" with puppet in socorro-vagrant
Categories
(Socorro :: General, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rhelmer, Assigned: rhelmer)
Details
Attachments
(1 file, 1 obsolete file)
|
2.25 KB,
patch
|
lonnen
:
review+
|
Details | Diff | Splinter Review |
Right now puppet clones the repo if "~socorro/dev/socorro" does not exist, and does a "git pull" in that directory on each run.
"git pull" returns non-0 if the user has changed the branch, and running puppet is the suggested way to deploy in the README.
We should just not have puppet do the "git pull" and leave that up to the user.
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Comment 2•14 years ago
|
||
Here's the actual change:
https://github.com/rhelmer/socorro-vagrant/commit/185ff632187d46399fae0e932c83c6d65cc18d41
Pull req just for the submodule update:
https://github.com/mozilla/socorro/pull/31
Attachment #560953 -
Attachment is obsolete: true
Attachment #560953 -
Flags: review?(chris.lonnen)
Attachment #560963 -
Flags: review?(chris.lonnen)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 560953 [details] [diff] [review]
update vagrant submodule to fix error on pull when branch not on master
merged as:
https://github.com/mozilla/socorro/commit/6f1ecf0dcde48860151eb1b246989914def25654
Attachment #560953 -
Flags: review+
|
|
||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Attachment #560963 -
Flags: review?(chris.lonnen) → review+
|
||
Updated•14 years ago
|
Component: Socorro → General
Product: Webtools → Socorro
You need to log in
before you can comment on or make changes to this bug.
Description
•