Closed Bug 687634 Opened 8 years ago Closed 8 years ago

testing blackImage->CairoStatus value twice in gfxXlibNativeRenderer::Draw

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: arno, Assigned: arno)

References

Details

Attachments

(1 file)

Hi,
in gfxXlibNativeRenderer::Draw, there is:
    if (blackImage->CairoStatus() == CAIRO_STATUS_SUCCESS &&
        blackImage->CairoStatus() == CAIRO_STATUS_SUCCESS) {

This has been changed in attachment 461146 [details] [diff] [review].
This is probably a typo where the second blackImage should be whiteImage
Attached patch patch proposalSplinter Review
Assignee: nobody → arno
Status: NEW → ASSIGNED
Attachment #561013 - Flags: review?(roc)
Comment on attachment 561013 [details] [diff] [review]
patch proposal

Review of attachment 561013 [details] [diff] [review]:
-----------------------------------------------------------------

Great catch!
Attachment #561013 - Flags: review?(roc) → review+
Keywords: checkin-needed
This is now in my queue of things that are being sent to try then onto inbound :-)
Keywords: checkin-needed
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/89d8b2add33f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.