Last Comment Bug 687634 - testing blackImage->CairoStatus value twice in gfxXlibNativeRenderer::Draw
: testing blackImage->CairoStatus value twice in gfxXlibNativeRenderer::Draw
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla9
Assigned To: arno renevier
:
Mentors:
Depends on:
Blocks: 579676
  Show dependency treegraph
 
Reported: 2011-09-19 13:56 PDT by arno renevier
Modified: 2011-09-21 02:52 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch proposal (1.29 KB, patch)
2011-09-19 14:09 PDT, arno renevier
roc: review+
Details | Diff | Review

Description arno renevier 2011-09-19 13:56:33 PDT
Hi,
in gfxXlibNativeRenderer::Draw, there is:
    if (blackImage->CairoStatus() == CAIRO_STATUS_SUCCESS &&
        blackImage->CairoStatus() == CAIRO_STATUS_SUCCESS) {

This has been changed in attachment 461146 [details] [diff] [review].
This is probably a typo where the second blackImage should be whiteImage
Comment 1 arno renevier 2011-09-19 14:09:07 PDT
Created attachment 561013 [details] [diff] [review]
patch proposal
Comment 2 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-09-19 15:31:34 PDT
Comment on attachment 561013 [details] [diff] [review]
patch proposal

Review of attachment 561013 [details] [diff] [review]:
-----------------------------------------------------------------

Great catch!
Comment 3 Ed Morley [:emorley] 2011-09-20 03:25:37 PDT
This is now in my queue of things that are being sent to try then onto inbound :-)
Comment 5 Marco Bonardo [::mak] 2011-09-21 02:52:54 PDT
https://hg.mozilla.org/mozilla-central/rev/89d8b2add33f

Note You need to log in before you can comment on or make changes to this bug.