The default bug view has changed. See this FAQ.

testing blackImage->CairoStatus value twice in gfxXlibNativeRenderer::Draw

RESOLVED FIXED in mozilla9

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: arno renevier, Assigned: arno renevier)

Tracking

Trunk
mozilla9
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Hi,
in gfxXlibNativeRenderer::Draw, there is:
    if (blackImage->CairoStatus() == CAIRO_STATUS_SUCCESS &&
        blackImage->CairoStatus() == CAIRO_STATUS_SUCCESS) {

This has been changed in attachment 461146 [details] [diff] [review].
This is probably a typo where the second blackImage should be whiteImage
(Assignee)

Comment 1

6 years ago
Created attachment 561013 [details] [diff] [review]
patch proposal
Assignee: nobody → arno
Status: NEW → ASSIGNED
Attachment #561013 - Flags: review?(roc)
Comment on attachment 561013 [details] [diff] [review]
patch proposal

Review of attachment 561013 [details] [diff] [review]:
-----------------------------------------------------------------

Great catch!
Attachment #561013 - Flags: review?(roc) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
This is now in my queue of things that are being sent to try then onto inbound :-)
Keywords: checkin-needed
Version: unspecified → Trunk
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=f07268905b26

https://hg.mozilla.org/integration/mozilla-inbound/rev/89d8b2add33f
Target Milestone: --- → mozilla9
https://hg.mozilla.org/mozilla-central/rev/89d8b2add33f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.