Closed
Bug 687642
Opened 13 years ago
Closed 13 years ago
Change JSOP_GETELEM to use the narrower, split-by-property-type APIs
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(2 files, 1 obsolete file)
4.39 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
12.63 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
This will give a pretty good idea how opcodes will be implemented using the property/index/special splitup. It's a fairly easy first step that should be digestible on its own. First step: PropertyName::isElement turns out to have been misnamed, should have been PropertyName::isIndex, so rename that. Second step: rewrite the JSOP_GETELEM implementations. This doesn't change any semantics, so I don't *think* I need to update the tracer, and I don't *think* I need to update PICs at all for it. (Although perhaps there might be ways they could be updated to take advantage of this. But that probably is better off waiting until the JSOp bytecodes are updated to be optimized for this split, since they aren't currently.) These patches only apply atop bug 687621's patches (plus one other, but I think that third patch doesn't affect these), in case you decide to try them out.
Attachment #561014 -
Flags: review?(dvander)
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #561015 -
Flags: review?(dvander)
Updated•13 years ago
|
Attachment #561014 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #561015 -
Attachment is obsolete: true
Attachment #561015 -
Flags: review?(dvander)
Attachment #561914 -
Flags: review?(dvander)
Assignee | ||
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f1a5172cced This is only the first patch here -- second still needs to land, so merge-monkeys shouldn't mark this as fixed yet. :-)
Comment 4•13 years ago
|
||
(In reply to Jeff Walden (remove +bmo to email) from comment #3) > This is only the first patch here -- second still needs to land, so > merge-monkeys shouldn't mark this as fixed yet. :-) Thanks ;-) Part 1: https://hg.mozilla.org/mozilla-central/rev/2f1a5172cced
Updated•13 years ago
|
Attachment #561914 -
Flags: review?(dvander) → review+
Comment 5•13 years ago
|
||
Part 2: https://hg.mozilla.org/mozilla-central/rev/0c2d5c359b0c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•