The default bug view has changed. See this FAQ.

Change JSOP_GETELEM to use the narrower, split-by-property-type APIs

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 561014 [details] [diff] [review]
1 - isIndex, not isElement

This will give a pretty good idea how opcodes will be implemented using the property/index/special splitup.  It's a fairly easy first step that should be digestible on its own.

First step: PropertyName::isElement turns out to have been misnamed, should have been PropertyName::isIndex, so rename that.  Second step: rewrite the JSOP_GETELEM implementations.  This doesn't change any semantics, so I don't *think* I need to update the tracer, and I don't *think* I need to update PICs at all for it.  (Although perhaps there might be ways they could be updated to take advantage of this.  But that probably is better off waiting until the JSOp bytecodes are updated to be optimized for this split, since they aren't currently.)

These patches only apply atop bug 687621's patches (plus one other, but I think that third patch doesn't affect these), in case you decide to try them out.
Attachment #561014 - Flags: review?(dvander)
Created attachment 561015 [details] [diff] [review]
2 - Inject the name/element/special split into JSOP_GETELEM
Attachment #561015 - Flags: review?(dvander)
Attachment #561014 - Flags: review?(dvander) → review+
Created attachment 561914 [details] [diff] [review]
2 - Unbitrotted
Attachment #561015 - Attachment is obsolete: true
Attachment #561015 - Flags: review?(dvander)
Attachment #561914 - Flags: review?(dvander)
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f1a5172cced

This is only the first patch here -- second still needs to land, so merge-monkeys shouldn't mark this as fixed yet.  :-)
(In reply to Jeff Walden (remove +bmo to email) from comment #3)
> This is only the first patch here -- second still needs to land, so
> merge-monkeys shouldn't mark this as fixed yet.  :-)

Thanks ;-)

Part 1: https://hg.mozilla.org/mozilla-central/rev/2f1a5172cced
Attachment #561914 - Flags: review?(dvander) → review+
Part 2: https://hg.mozilla.org/mozilla-central/rev/0c2d5c359b0c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.