687690 - Affiliates: Move country to address section in edit profile

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Chris More [:cmore]]

The locale of the users should be used to determine the user's country and set in the profile automatically now that there is no activation form asking for country.

Comment 1

[Osmose [:osmose, :mkelly]]

chelsea: So it seems that auto-determining the user's country from their locale is not reasonable. We could use other methods, but I've heard from other projects that auto-determining a user's country is not a good idea; users get angry sometimes when it assumes they live in the same place that their preferred language is from.

I suggest that we make the country field optional and move it to the address area of the edit profile form. I also suggest that we remove the blurb explaining how the country and locale were auto-detected, considering that the country was not auto-detected.

Thoughts?

Comment 2

[Fred Wenzel [:wenzel]]

You can always use the GeoIP API, but then you still need to map the geographical location to the political country, which seems overkill to me. Plus the popup "affiliates wants to know your location" could be disconcerting to the user and overkill in this context.

Comment 3

[Paul Booker]

(In reply to Michael Kelly [:mkelly] from comment #1)
> chelsea: So it seems that auto-determining the user's country from their
> locale is not reasonable. We could use other methods, but I've heard from
> other projects that auto-determining a user's country is not a good idea;
> users get angry sometimes when it assumes they live in the same place that
> their preferred language is from.
> 
> I suggest that we make the country field optional and move it to the address
> area of the edit profile form. I also suggest that we remove the blurb
> explaining how the country and locale were auto-detected, considering that
> the country was not auto-detected.
> 
> Thoughts?

I agree with the feedback from Chelsea. It looks as though these ideas are already in that latest code on github :-) 

Shall we have default country set to be something like "Not Selected" instead of  Afghanistan?

Comment 4

[Chelsea Novak [:chelsea]]

Sorry mkelly, I didn't see this bug. Agreed with your suggestion. Sorry for the delay!

Comment 5

[Paul Booker]

Agree it does seem like an overkill. With this approach do you have to also assume that the country attributed to the  location of the ISP that gives out the IP  will match the location of the user? which i suppose it would more times than not.

// Paul Booker

Comment 6

[Chris More [:cmore]]

Mkelly Chelsea: I agree that this is an overkill and getting the country from the locale probably will not be very accurate or desired from the end user.

Comment 7

[Osmose [:osmose, :mkelly]]

Scope of this bug is changed to moving the country field and removing the help blurb, then.

Comment 8

[[github robot]]

Commit pushed to https://github.com/mozilla/affiliates

https://github.com/mozilla/affiliates/commit/40a530cf177ba2afc39df438fd61b3a3c2081eb1
Make country optional and move to address.

Also removes the info blurb explaining that country is detected automatically,
because it isn't.

fix bug 687690

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://affiliates-dev.allizom.org/en-US/accounts/edit.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot