Add offline renderer awareness for Mac OGL

RESOLVED FIXED in mozilla9

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

unspecified
mozilla9
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
http://developer.apple.com/library/mac/#technotes/tn2229/_index.html

In a nutshell we need to declare our renderers as offline renderer aware and handle renderer change notification.
(Assignee)

Updated

6 years ago
Depends on: 687868
(Assignee)

Updated

6 years ago
Blocks: 604135
(Assignee)

Updated

6 years ago
Blocks: 568327
(Assignee)

Updated

6 years ago
Blocks: 646043
(Assignee)

Comment 1

6 years ago
Created attachment 561539 [details] [diff] [review]
Workaround for blocker 687868 - Don't check for Layers support
(Assignee)

Comment 2

6 years ago
Created attachment 561540 [details] [diff] [review]
Part 1: Add offline renderer awareness for Mac OGL in browser
Attachment #561540 - Flags: review?(jmuizelaar)
(Assignee)

Comment 3

6 years ago
Created attachment 561541 [details] [diff] [review]
Part 2: Add offline renderer awareness for Mac OGL in plugins
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #561541 - Flags: review?(jmuizelaar)
(Assignee)

Comment 4

6 years ago
I don't check for renderer change notification currently. Do we need to update feature status that may differ between the two gpus?
(Assignee)

Comment 5

6 years ago
Push to try:
https://tbpl.mozilla.org/?tree=Try&rev=478de21a4a56
Comment on attachment 561540 [details] [diff] [review]
Part 1: Add offline renderer awareness for Mac OGL in browser

The way we set double buffer is sort of scary...

I also just thought about the impact that a change in max texture size could have on us.
Attachment #561540 - Flags: review?(jmuizelaar) → review+
Comment on attachment 561541 [details] [diff] [review]
Part 2: Add offline renderer awareness for Mac OGL in plugins

It might be worth adding a comment near where we create the PBuffer that worries about it and mentions this url:http://developer.apple.com/library/mac/#technotes/tn2229/_index.html#//apple_ref/doc/uid/DTS40008924-CH1-SECTION7
Attachment #561541 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 8

6 years ago
Bug 687868 is no longer required FOR RELEASE BUILDS because apple sniffs our bundle ID
No longer depends on: 687868
Keywords: checkin-needed
Depends on: 687868

Comment 9

6 years ago
The try run in comment 5 shows the same OS X64 debug M-oth orange twice in a row. Is it related? I've retriggered it again to see if it was just bad luck with a not yet filed random orange.
(Assignee)

Comment 10

6 years ago
I don't think they are related. This change can only get properly tested with hardware with dual gpu so I don't expected we would see any regression on tinderbox.

In any case I'll hold on check-in flag until this is resolved.
Keywords: checkin-needed
(Assignee)

Comment 11

6 years ago
https://hg.mozilla.org/mozilla-central/rev/5c52fd250a41
https://hg.mozilla.org/mozilla-central/rev/2c5bbb176d01
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

Comment 12

6 years ago
I see this is marked fixed. What is the timeline for releasing this fix?
(Assignee)

Comment 13

6 years ago
Target is mozilla9, that's 20-Dec-11.
(Assignee)

Updated

6 years ago
Depends on: 714723

Updated

6 years ago
Blocks: 721285
You need to log in before you can comment on or make changes to this bug.