687864 - Add offline renderer awareness for Mac OGL

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

http://developer.apple.com/library/mac/#technotes/tn2229/_index.html

In a nutshell we need to declare our renderers as offline renderer aware and handle renderer change notification.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: Workaround for blocker 687868 - Don't check for Layers support

Comment 2

[Benoit Girard (:BenWa)]

Attachment: Part 1: Add offline renderer awareness for Mac OGL in browser

Comment 3

[Benoit Girard (:BenWa)]

Attachment: Part 2: Add offline renderer awareness for Mac OGL in plugins

Comment 4

[Benoit Girard (:BenWa)]

I don't check for renderer change notification currently. Do we need to update feature status that may differ between the two gpus?

Comment 5

[Benoit Girard (:BenWa)]

Push to try:
https://tbpl.mozilla.org/?tree=Try&rev=478de21a4a56

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 561540 [details] [diff] [review]
Part 1: Add offline renderer awareness for Mac OGL in browser

The way we set double buffer is sort of scary...

I also just thought about the impact that a change in max texture size could have on us.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 561541 [details] [diff] [review]
Part 2: Add offline renderer awareness for Mac OGL in plugins

It might be worth adding a comment near where we create the PBuffer that worries about it and mentions this url:http://developer.apple.com/library/mac/#technotes/tn2229/_index.html#//apple_ref/doc/uid/DTS40008924-CH1-SECTION7

Comment 8

[Benoit Girard (:BenWa)]

Bug 687868 is no longer required FOR RELEASE BUILDS because apple sniffs our bundle ID

Comment 9

[Ed Morley [:emorley]]

The try run in comment 5 shows the same OS X64 debug M-oth orange twice in a row. Is it related? I've retriggered it again to see if it was just bad luck with a not yet filed random orange.

Comment 10

[Benoit Girard (:BenWa)]

I don't think they are related. This change can only get properly tested with hardware with dual gpu so I don't expected we would see any regression on tinderbox.

In any case I'll hold on check-in flag until this is resolved.

Comment 11

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/mozilla-central/rev/5c52fd250a41
https://hg.mozilla.org/mozilla-central/rev/2c5bbb176d01

Comment 12

[Ty Williams]

I see this is marked fixed. What is the timeline for releasing this fix?

Comment 13

[Benoit Girard (:BenWa)]

Target is mozilla9, that's 20-Dec-11.