Closed Bug 687885 Opened 8 years ago Closed 8 years ago

Don't use resetUseCount() outside of ifdef JS_METHODJIT

Categories

(Core :: JavaScript Engine, defect)

Sun
OpenBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: gaston, Unassigned)

Details

Attachments

(1 file)

Followup to that commit : http://hg.mozilla.org/mozilla-central/rev/9ca3d16d575c

Build now fails on sparc64 (where JS_METHODJIT is undef) with :
js/src/jsinfer.cpp:6041: error: 'struct JSScript' has no member named 'resetUseCount'

See http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/165/steps/build/logs/stdio

Imo the call should be included within JS_METHODJIT as the releaseScriptCode call upper.
Attached patch Proposed fixSplinter Review
Trying that patch here, results in http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/166/steps/build/logs/stdio and apparently it fixes the build issue.
Attachment #561218 - Flags: review?(bhackett1024)
Attachment #561218 - Flags: review?(bhackett1024) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/21a39c2f9060
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Is possibly the cause of the macosx-debug_spidermonkey-shark builds going orange: (NB you need to use TBPL &usetinderbox=1 so the logs show up, due to bug 685299)

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usetinderbox=1&jobname=spidermonkey&rev=21a39c2f9060

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1316539496.1316543246.4464.gz

The last JS touching changing before this (https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usetinderbox=1&jobname=spidermonkey&rev=5a3e49205389) was green.
Whiteboard: inbound
You need to log in before you can comment on or make changes to this bug.