Don't use resetUseCount() outside of ifdef JS_METHODJIT

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gaston, Unassigned)

Tracking

Trunk
mozilla9
Sun
OpenBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Followup to that commit : http://hg.mozilla.org/mozilla-central/rev/9ca3d16d575c

Build now fails on sparc64 (where JS_METHODJIT is undef) with :
js/src/jsinfer.cpp:6041: error: 'struct JSScript' has no member named 'resetUseCount'

See http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/165/steps/build/logs/stdio

Imo the call should be included within JS_METHODJIT as the releaseScriptCode call upper.
(Reporter)

Comment 1

6 years ago
Created attachment 561218 [details] [diff] [review]
Proposed fix

Trying that patch here, results in http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/166/steps/build/logs/stdio and apparently it fixes the build issue.
Attachment #561218 - Flags: review?(bhackett1024)
Attachment #561218 - Flags: review?(bhackett1024) → review+
(Reporter)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/21a39c2f9060
Keywords: checkin-needed
Whiteboard: inbound
https://hg.mozilla.org/mozilla-central/rev/21a39c2f9060
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

Comment 4

6 years ago
Is possibly the cause of the macosx-debug_spidermonkey-shark builds going orange: (NB you need to use TBPL &usetinderbox=1 so the logs show up, due to bug 685299)

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usetinderbox=1&jobname=spidermonkey&rev=21a39c2f9060

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1316539496.1316543246.4464.gz

The last JS touching changing before this (https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usetinderbox=1&jobname=spidermonkey&rev=5a3e49205389) was green.

Updated

6 years ago
Whiteboard: inbound
You need to log in before you can comment on or make changes to this bug.