687974 - allow talos to run tests via adb

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

currently talos is SUT only, we need to make this run in SUT and ADB.

Comment 1

[Mike Taylor [:bear]]

do we need to file a bug to get watcher to enable adb-over-tcp/ip all the time?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: devicemanager libraries for talos- from m-c (1.0)

bear, can you do a quick sanity check on this patch.  I know it is big, but do a diff on mozilla-central for the 3 files  Iam touching, they are a straight copy.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: allow use of adb when --remotePort=-1 (1.0)

this patch fixes up all instances in talos to use ADB instead of SUT for devicemanager when we find that the --remotePort is -1 (default currently is 20701)

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

:bear, interesting.  I think we should file a bug to do that, but this patch is for giving developers support to run talos on any given device.  On a side note, I have had some reliability problems connecting to device with adb via tcp, specifically when it comes to installing builds.

Comment 5

[Mike Taylor [:bear]]

Comment on attachment 561277 [details] [diff] [review]
devicemanager libraries for talos- from m-c (1.0)

this big of a change needs to be tested even with a review - so take my r+ as a "don't see anything stupid" stamp and let's start testing it

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

bear, we will also need to update the sut_tools scripts before running these.  I can put up a patch tomorrow that will do that.

Comment 7

[alice nodelman [:alice] [:anode]]

Comment on attachment 561278 [details] [diff] [review]
allow use of  adb when --remotePort=-1 (1.0)

+    import devicemanager, devicemanagerADB, devicemanagerSUT

I would limit the import of devicemanagerADB/devicemanagerSUT based upon the port variable.  Other than that nit, it looks good.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

landed on build/talos:
http://hg.mozilla.org/build/talos/rev/bc8fc61eb80d
http://hg.mozilla.org/build/talos/rev/158dbaee6844

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

we will need to coordinate a rollout on mobile with release engineering as the sut_tools need to be updated once this goes live.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

filed bug 688722 for the sut_tools version.

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

filed bug 688722 for the sut_tools version.