Closed Bug 687974 Opened 10 years ago Closed 10 years ago

allow talos to run tests via adb

Categories

(Testing :: Talos, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

(Whiteboard: [mobile_unittests])

Attachments

(2 files)

currently talos is SUT only, we need to make this run in SUT and ADB.
do we need to file a bug to get watcher to enable adb-over-tcp/ip all the time?
bear, can you do a quick sanity check on this patch.  I know it is big, but do a diff on mozilla-central for the 3 files  Iam touching, they are a straight copy.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #561277 - Flags: review?(bear)
this patch fixes up all instances in talos to use ADB instead of SUT for devicemanager when we find that the --remotePort is -1 (default currently is 20701)
Attachment #561278 - Flags: review?(anodelman)
:bear, interesting.  I think we should file a bug to do that, but this patch is for giving developers support to run talos on any given device.  On a side note, I have had some reliability problems connecting to device with adb via tcp, specifically when it comes to installing builds.
Comment on attachment 561277 [details] [diff] [review]
devicemanager libraries for talos- from m-c (1.0)

this big of a change needs to be tested even with a review - so take my r+ as a "don't see anything stupid" stamp and let's start testing it
Attachment #561277 - Flags: review?(bear) → review+
bear, we will also need to update the sut_tools scripts before running these.  I can put up a patch tomorrow that will do that.
Comment on attachment 561278 [details] [diff] [review]
allow use of  adb when --remotePort=-1 (1.0)

+    import devicemanager, devicemanagerADB, devicemanagerSUT

I would limit the import of devicemanagerADB/devicemanagerSUT based upon the port variable.  Other than that nit, it looks good.
Attachment #561278 - Flags: review?(anodelman) → review+
we will need to coordinate a rollout on mobile with release engineering as the sut_tools need to be updated once this goes live.
Blocks: 688722
filed bug 688722 for the sut_tools version.
filed bug 688722 for the sut_tools version.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.