Last Comment Bug 688081 - Reorder condition checks in RequestDecode()
: Reorder condition checks in RequestDecode()
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: ImageLib (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla9
Assigned To: Jeff Muizelaar [:jrmuizel]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-20 19:03 PDT by Jeff Muizelaar [:jrmuizel]
Modified: 2011-09-23 05:00 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Reorder condition checks in RequestDecode() (1.11 KB, patch)
2011-09-20 19:03 PDT, Jeff Muizelaar [:jrmuizel]
joe: review+
Details | Diff | Splinter Review

Description Jeff Muizelaar [:jrmuizel] 2011-09-20 19:03:42 PDT
Created attachment 561368 [details] [diff] [review]
Reorder condition checks in RequestDecode()

This matches better with the no-op intent of RequestDecode() and will be true more often once decode on draw is enabled which will give an earlier exit.

It also makes my debugging easier.
Comment 1 Ed Morley [:emorley] 2011-09-23 05:00:29 PDT
https://hg.mozilla.org/mozilla-central/rev/8cfe90773812


When attaching patches, can you use the "take bug and set the bug status to" checkbox to set assignee automatically, as it saves me having to fix it on merge. Thanks :-)

Note You need to log in before you can comment on or make changes to this bug.