Last Comment Bug 688174 - IonMonkey: LInstruction::InputIterator should support instruction with snapshot and no operands.
: IonMonkey: LInstruction::InputIterator should support instruction with snapsh...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Nicolas B. Pierron [:nbp]
:
Mentors:
Depends on:
Blocks: 685838 689325
  Show dependency treegraph
 
Reported: 2011-09-21 09:17 PDT by Nicolas B. Pierron [:nbp]
Modified: 2011-10-10 17:53 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Extract next function end and call it in the init. (1.19 KB, patch)
2011-09-21 11:08 PDT, Nicolas B. Pierron [:nbp]
dvander: review+
Details | Diff | Splinter Review

Description Nicolas B. Pierron [:nbp] 2011-09-21 09:17:01 PDT
Lir instructions such as LNewArray (JSOP_NEwARRAY) may need to allocate a new object before filling it.  These kind of instruction implies have no operands and need a snapshot.

LInstruction::InputIterator does not yet handle the case where an instruction has no operand before switching to the snapshot.
Comment 1 Nicolas B. Pierron [:nbp] 2011-09-21 11:08:09 PDT
Created attachment 561523 [details] [diff] [review]
Extract next function end and call it in the init.
Comment 2 David Anderson [:dvander] 2011-09-21 18:38:38 PDT
Comment on attachment 561523 [details] [diff] [review]
Extract next function end and call it in the init.

Review of attachment 561523 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.

::: js/src/ion/IonLIR.h
@@ +808,4 @@
>      size_t idx_;
>      bool snapshot_;
>  
> +    void handle_operands_end() {

nit: House style is camel-case, i.e. handleOperandsEnd()

r=me with that
Comment 3 David Anderson [:dvander] 2011-10-10 17:53:28 PDT
http://hg.mozilla.org/projects/ionmonkey/rev/67d5e0dec3fa

Note You need to log in before you can comment on or make changes to this bug.