Note: There are a few cases of duplicates in user autocompletion which are being worked on.

IonMonkey: LInstruction::InputIterator should support instruction with snapshot and no operands.

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: nbp, Assigned: nbp)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Lir instructions such as LNewArray (JSOP_NEwARRAY) may need to allocate a new object before filling it.  These kind of instruction implies have no operands and need a snapshot.

LInstruction::InputIterator does not yet handle the case where an instruction has no operand before switching to the snapshot.
(Assignee)

Comment 1

6 years ago
Created attachment 561523 [details] [diff] [review]
Extract next function end and call it in the init.
Attachment #561523 - Flags: review?(dvander)
Comment on attachment 561523 [details] [diff] [review]
Extract next function end and call it in the init.

Review of attachment 561523 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.

::: js/src/ion/IonLIR.h
@@ +808,4 @@
>      size_t idx_;
>      bool snapshot_;
>  
> +    void handle_operands_end() {

nit: House style is camel-case, i.e. handleOperandsEnd()

r=me with that
Attachment #561523 - Flags: review?(dvander) → review+
Blocks: 689325
http://hg.mozilla.org/projects/ionmonkey/rev/67d5e0dec3fa
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.