Closed
Bug 688174
Opened 13 years ago
Closed 13 years ago
IonMonkey: LInstruction::InputIterator should support instruction with snapshot and no operands.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: nbp, Assigned: nbp)
References
Details
Attachments
(1 file)
1.19 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Lir instructions such as LNewArray (JSOP_NEwARRAY) may need to allocate a new object before filling it. These kind of instruction implies have no operands and need a snapshot. LInstruction::InputIterator does not yet handle the case where an instruction has no operand before switching to the snapshot.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #561523 -
Flags: review?(dvander)
Comment on attachment 561523 [details] [diff] [review] Extract next function end and call it in the init. Review of attachment 561523 [details] [diff] [review]: ----------------------------------------------------------------- Good catch. ::: js/src/ion/IonLIR.h @@ +808,4 @@ > size_t idx_; > bool snapshot_; > > + void handle_operands_end() { nit: House style is camel-case, i.e. handleOperandsEnd() r=me with that
Attachment #561523 -
Flags: review?(dvander) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/67d5e0dec3fa
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•