688174 - IonMonkey: LInstruction::InputIterator should support instruction with snapshot and no operands.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicolas B. Pierron [:nbp]]

Lir instructions such as LNewArray (JSOP_NEwARRAY) may need to allocate a new object before filling it.  These kind of instruction implies have no operands and need a snapshot.

LInstruction::InputIterator does not yet handle the case where an instruction has no operand before switching to the snapshot.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Extract next function end and call it in the init.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 561523 [details] [diff] [review]
Extract next function end and call it in the init.

Review of attachment 561523 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.

::: js/src/ion/IonLIR.h
@@ +808,4 @@
>      size_t idx_;
>      bool snapshot_;
>  
> +    void handle_operands_end() {

nit: House style is camel-case, i.e. handleOperandsEnd()

r=me with that

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/projects/ionmonkey/rev/67d5e0dec3fa