688208 - nsWindow for Android doesn't check whether the instance is destroying or not after dispatching an event

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Android's nsWindow doesn't hold itself and doesn't check whether it's destroying or not after dispatching an event. I'm not sure that actually causes crash bugs. We should research it.

nsWindow might be destroyed by DOM event handler. Mac's widget has fixed this already but I'm not sure the detail and bug#. Steven probably knows the bug#.

I think nsWindow for Android should do:

+    nsRefPtr<nsWindow> kungFuDeathGrip(this);
     DispatchEvent(event);
+    if (Destroyed()) {
+        return;
+    }

And:

nsWindow should set nsBaseWidget::mOnDestroyCalled to TRUE when it's destroying.
# It seems that nsBaseWidget::OnDestroy() should be called too...

Comment 1

[Daniel Veditz [:dveditz]]

Don't know enough about android to confirm this, but plausibly sg:critical based on analogy with other platforms.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Bug 402505 is the one where this issue was happening on Mac. I tried the test cases from that bug on android and they didn't trigger any crashes. I'll keep investigating and try other ways to trigger the crash before concluding one way or another.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

So I wasn't able to trigger the crash mostly because it seems impossible to close the window on Android. After discussing with blassey, it makes sense to fix this anyway since in the future it might be possible to close windows and this bug might show up. Will attach two patches (one for the missing nsBaseWidget::OnDestroy() call, and one for the kungFuDeathGrip stuff.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: OnDestroy patch rev. 1

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: kungFu patch rev. 1

Sorry, forgot to check the patch box on the previous one.

Comment 6

[Doug Turner (:dougt)]

kats, can you build a test case that opens two xul windows and programatically close them?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 565375 [details] [diff] [review]
kungFu patch rev. 1

Each platform seems to handle these "check for destroyed after a DOM event" differently, but it looks like you have things covered here. Certainly better covered than before.

It's also true that we don't have really great ways to test these cases yet either.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: OnDestroy patch rev. 2

Rebase to m-c tip and update patch so that it is an hg export with commit message rather than a raw diff.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: kungFu patch rev. 2

Rebase to m-c tip and update patch so that it is an hg export with commit message rather than a raw diff.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=a0ad3f7fac68

Pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d34c48393e3b
https://hg.mozilla.org/integration/mozilla-inbound/rev/d10af1d1d985

Comment 11

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/d10af1d1d985
https://hg.mozilla.org/mozilla-central/rev/d34c48393e3b

Comment 12

[Daniel Veditz [:dveditz]]

Since we're shipping XUL Mobile "11" based on ESR so we will need to fix this one on the ESR in order to get this mobile-only security fix out to users.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

[Triage comment]

This bug is being tracked for landing on ESR branch.  Please land patches on http://hg.mozilla.org/releases/mozilla-esr10/by Thursday March 1, 2012 in order to be ready for go-to-build on Friday March 2, 2012.

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more information.

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Landed on the mozilla-esr10 repository:

https://hg.mozilla.org/releases/mozilla-esr10/rev/9d8331f4e43b
https://hg.mozilla.org/releases/mozilla-esr10/rev/4663a567d884

Comment 15

[Al Billings [:abillings - ex-MoCo]]

Did we create a way to test this fix? I see comments about doing so but that's it.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

No, IIRC we couldn't find a way to test this behaviour properly.

Comment 17

[Al Billings [:abillings - ex-MoCo]]

Not a 1.9.2 issue. Marking as unaffected.

Comment 18

[u279076]

Untracking from QA Firefox Desktop verifications