688223 - Re-prompt user for telemetry opt-in if privacy policy changes

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[(dormant account)]

This is needed to ensure that we do not surprise users

Comment 1

[(dormant account)]

Attachment: reprompt

Comment 2

[(dormant account)]

This changes prompting logic to wipe opt-in pref if the telemetry prompt got revised.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 562841 [details] [diff] [review]
reprompt

This looks OK, except that you lost the ability to prevent prompting altogether by having toolkit.telemetry.enabled default to false - I think we should preserve that.

Comment 4

[(dormant account)]

(In reply to Gavin Sharp (use [e-mail] for email) from comment #3)
> Comment on attachment 562841 [details] [diff] [review] [diff] [details] [review]
> reprompt
> 
> This looks OK, except that you lost the ability to prevent prompting
> altogether by having toolkit.telemetry.enabled default to false - I think we
> should preserve that.


-      if (Services.prefs.getBoolPref(PREF_TELEMETRY_ENABLED) ||
-          Services.prefs.getBoolPref(PREF_TELEMETRY_PROMPTED))
-         return;

Gavin, I don't believe there was such ability here.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Oh, indeed you're right. I think we should have a mechanism for disabling the prompting, though (and I guess it can't be the enabled pref).

Comment 6

[(dormant account)]

(In reply to Gavin Sharp (use [e-mail] for email) from comment #5)
> Oh, indeed you're right. I think we should have a mechanism for disabling
> the prompting, though (and I guess it can't be the enabled pref).

It's disabled by default unless you set a build flag to enable telemetry. You can also disable prompting by setting telemetry.prompted pref to 2

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Build-time options aren't ideal if we're building with it enabled (people want to repackage our builds), and setting the PROMPTED pref to 2 will break when we bump the version to 3. Anyways, this doesn't need to block this bug - I will file a followup.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 562841 [details] [diff] [review]
reprompt

Please get rid of the else-after-return.

Comment 9

[Mozilla RelEng Bot]

Try run for 74c38a4eec18 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=74c38a4eec18
Results (out of 47 total builds):
    success: 44
    warnings: 3
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-74c38a4eec18

Comment 10

[(dormant account)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4a590adce18c

Comment 11

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/4a590adce18c

Comment 12

[(dormant account)]

Comment on attachment 562841 [details] [diff] [review]
reprompt

We need to land this(along with bug 691951) in ff8 in order to not have to disable telemetry + backout probes

Comment 13

[LegNeato]

[triage comment]

Firefox 8 is already out the door, earliest this can make it in in 9 / aurora. Approved there.

Comment 14

[LegNeato]

Comment on attachment 562841 [details] [diff] [review]
reprompt

[triage comment]

Please land on mozilla-aurora today.

Comment 15

[Alex Keybl [:akeybl]]

[Triage Comment]
This bug was approved for Aurora while Firefox 9 was on that channel. If there's reason to now take this for Firefox 9 on Beta, please set approval-mozilla-beta?

Comment 16

[Alex Keybl [:akeybl]]

Comment on attachment 562841 [details] [diff] [review]
reprompt

[Triage Comment]
Approving for Beta since this didn't make the merge last week.

Please land today so that this goes into our next Beta.

Comment 17

[(dormant account)]

http://hg.mozilla.org/releases/mozilla-beta/rev/5f3ae37671e5

Comment 18

[Vlad [QA]]

Hi guys.

The default settings in:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0 beta 4 are

toolkit.telemetry.enabled is set to false
telemetry.prompted pref is set to 2.

How can I verify that this bug is resolved?  How can I get the prompt?

Thanks

Comment 19

[u279076]

[qa?] until we get an answer to comment 18...

Comment 20

[(dormant account)]

(In reply to Vlad [QA] from comment #18)
> Hi guys.
> 
> The default settings in:
> Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101
> Firefox/9.0 beta 4 are
> 
> toolkit.telemetry.enabled is set to false
> telemetry.prompted pref is set to 2.
> 
> How can I verify that this bug is resolved?  How can I get the prompt?
> 
> Thanks

delete telemetry.prompted pref

Comment 21

[u279076]

Vlad, as per Taras' comment, delete the telemetry.prompted pref and retest.

Comment 22

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0

I've set the telemetry.prompted to 0 and the prompt appeared after Firefox restart. In about:config, the value is set back to 2.