Closed Bug 688223 Opened 8 years ago Closed 8 years ago

Re-prompt user for telemetry opt-in if privacy policy changes

Categories

(Toolkit :: Telemetry, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10
Tracking Status
firefox9 --- fixed

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

Details

(Keywords: verified-beta, Whiteboard: [qa!:9] [qa+])

Attachments

(1 file)

This is needed to ensure that we do not surprise users
Attached patch repromptSplinter Review
Assignee: nobody → tglek
Attachment #562841 - Flags: review?
Attachment #562841 - Flags: review? → review?(gavin.sharp)
This changes prompting logic to wipe opt-in pref if the telemetry prompt got revised.
Comment on attachment 562841 [details] [diff] [review]
reprompt

This looks OK, except that you lost the ability to prevent prompting altogether by having toolkit.telemetry.enabled default to false - I think we should preserve that.
Attachment #562841 - Flags: review?(gavin.sharp) → review-
(In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #3)
> Comment on attachment 562841 [details] [diff] [review] [diff] [details] [review]
> reprompt
> 
> This looks OK, except that you lost the ability to prevent prompting
> altogether by having toolkit.telemetry.enabled default to false - I think we
> should preserve that.


-      if (Services.prefs.getBoolPref(PREF_TELEMETRY_ENABLED) ||
-          Services.prefs.getBoolPref(PREF_TELEMETRY_PROMPTED))
-         return;

Gavin, I don't believe there was such ability here.
Oh, indeed you're right. I think we should have a mechanism for disabling the prompting, though (and I guess it can't be the enabled pref).
(In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #5)
> Oh, indeed you're right. I think we should have a mechanism for disabling
> the prompting, though (and I guess it can't be the enabled pref).

It's disabled by default unless you set a build flag to enable telemetry. You can also disable prompting by setting telemetry.prompted pref to 2
Build-time options aren't ideal if we're building with it enabled (people want to repackage our builds), and setting the PROMPTED pref to 2 will break when we bump the version to 3. Anyways, this doesn't need to block this bug - I will file a followup.
Comment on attachment 562841 [details] [diff] [review]
reprompt

Please get rid of the else-after-return.
Attachment #562841 - Flags: review- → review+
Try run for 74c38a4eec18 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=74c38a4eec18
Results (out of 47 total builds):
    success: 44
    warnings: 3
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/tglek@mozilla.com-74c38a4eec18
https://hg.mozilla.org/mozilla-central/rev/4a590adce18c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
Comment on attachment 562841 [details] [diff] [review]
reprompt

We need to land this(along with bug 691951) in ff8 in order to not have to disable telemetry + backout probes
Attachment #562841 - Flags: approval-mozilla-aurora?
[triage comment]

Firefox 8 is already out the door, earliest this can make it in in 9 / aurora. Approved there.
Comment on attachment 562841 [details] [diff] [review]
reprompt

[triage comment]

Please land on mozilla-aurora today.
Attachment #562841 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
[Triage Comment]
This bug was approved for Aurora while Firefox 9 was on that channel. If there's reason to now take this for Firefox 9 on Beta, please set approval-mozilla-beta?
Attachment #562841 - Flags: approval-mozilla-beta?
Comment on attachment 562841 [details] [diff] [review]
reprompt

[Triage Comment]
Approving for Beta since this didn't make the merge last week.

Please land today so that this goes into our next Beta.
Attachment #562841 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [qa+]
Hi guys.

The default settings in:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0 beta 4 are

toolkit.telemetry.enabled is set to false
telemetry.prompted pref is set to 2.

How can I verify that this bug is resolved?  How can I get the prompt?

Thanks
[qa?] until we get an answer to comment 18...
Whiteboard: [qa+] → [qa?]
(In reply to Vlad [QA] from comment #18)
> Hi guys.
> 
> The default settings in:
> Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101
> Firefox/9.0 beta 4 are
> 
> toolkit.telemetry.enabled is set to false
> telemetry.prompted pref is set to 2.
> 
> How can I verify that this bug is resolved?  How can I get the prompt?
> 
> Thanks

delete telemetry.prompted pref
Vlad, as per Taras' comment, delete the telemetry.prompted pref and retest.
Whiteboard: [qa?] → [qa+]
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0

I've set the telemetry.prompted to 0 and the prompt appeared after Firefox restart. In about:config, the value is set back to 2.
Keywords: verified-beta
Whiteboard: [qa+] → [qa!:9] [qa+]
You need to log in before you can comment on or make changes to this bug.