688238 - Move Init() arguments into the constructor

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Move Init() arguments into the constructor

This makes the lifetime of the arguments more clear. i.e. that they stay the same for the lifetime of the decoder.

Comment 1

[Joe Drew (not getting mail)]

Comment on attachment 561535 [details] [diff] [review]
Move Init() arguments into the constructor

Review of attachment 561535 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpr0n/decoders/nsBMPDecoder.cpp
@@ +63,5 @@
>  #define LINE(row) ((mBIH.height < 0) ? (-mBIH.height - (row)) : ((row) - 1))
>  #define PIXEL_OFFSET(row, col) (LINE(row) * mBIH.width + col)
>  
> +nsBMPDecoder::nsBMPDecoder(RasterImage *aImage, imgIDecoderObserver* aObserver) :
> +    Decoder(aImage, aObserver)

: on the same line as Decoder(. Do this throughout.

::: modules/libpr0n/src/Decoder.h
@@ +56,5 @@
>    /**
>     * Initialize an image decoder. Decoders may not be re-initialized.
>     *
>     * @param aContainer The image container to decode to.
>     * @param aObserver The observer for decode notification events.

This documentation needs to be moved to the constructor.

@@ +68,5 @@
>     * Initializes a decoder whose aImage and aObserver is already being used by a
>     * parent decoder. Decoders may not be re-initialized.
>     *
>     * @param aContainer The image container to decode to.
>     * @param aObserver The observer for decode notification events.

Ditto.

Comment 2

[Michael Wu [:mwu]]

https://hg.mozilla.org/mozilla-central/rev/cd9a14388367