buildtools python module conflicts with an xcode provided python module

RESOLVED FIXED

Status

defect
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: jhford, Assigned: lsblakk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

/tools/lib/python/buildtools/__init__.py conflicts with a python module provided by Xcode, /System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/plat-mac/buildtools.py

This causes import exceptions when running buildbot on my Mac system.  It also complicates things for anyone looking to do mozilla buildbot development on their mac system.  I am using a virtualenv, but rely on system site packages because some of the modules I have need special compile steps with Xcode 4.

Lets rename this module to something else that doesn't conflict with system packages.


Traceback (most recent call last):
  File "/Users/jhford/mozilla/puppet-10.6/lib/python2.6/site-packages/buildbot-0.8.2_hg_93b5fefe8474_default-py2.6.egg/buildbot/scripts/runner.py", line 1039, in doCheckConfig
    ConfigLoader(configFileName=configFileName)
  File "/Users/jhford/mozilla/puppet-10.6/lib/python2.6/site-packages/buildbot-0.8.2_hg_93b5fefe8474_default-py2.6.egg/buildbot/scripts/checkconfig.py", line 31, in __init__
    self.loadConfig(configFile, check_synchronously_only=True)
  File "/Users/jhford/mozilla/puppet-10.6/lib/python2.6/site-packages/buildbot-0.8.2_hg_93b5fefe8474_default-py2.6.egg/buildbot/master.py", line 628, in loadConfig
    exec f in localDict
  File "/Users/jhford/mozilla/puppet-10.6/test-master/master.cfg", line 5, in <module>
    import buildbotcustom.misc
  File "/Users/jhford/mozilla/puppet-10.6/buildbotcustom/misc.py", line 31, in <module>
    import buildtools.queuedir
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/plat-mac/buildtools.py", line 18, in <module>
    import EasyDialogs
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/plat-mac/EasyDialogs.py", line 24, in <module>
    from Carbon.Dlg import GetNewDialog, SetDialogItemText, GetDialogItemText, ModalDialog
ImportError: cannot import name GetNewDialog
Posted patch buildbot-configs v1 (obsolete) — Splinter Review
This corrects buildbotcustom imports
Assignee: nobody → jhford
Status: NEW → ASSIGNED
Attachment #561583 - Flags: review?(catlee)
Attachment #561584 - Flags: review?(catlee)
Posted patch tools v1 (obsolete) — Splinter Review
Attachment #561585 - Flags: review?(catlee)
jhford: is this blocking any other work? I'm worried specifically about bug 681726.
It means that I am unable to test my patches locally while this issue is open, which makes it very slow to work on the buildbot patches.
Comment on attachment 561585 [details] [diff] [review]
tools v1

Review of attachment 561585 [details] [diff] [review]:
-----------------------------------------------------------------

you need to update scripts in buildbot-helpers too (command_runner.py, pulse_publisher.py)
Attachment #561585 - Flags: review?(catlee) → review-
Attachment #561584 - Flags: review?(catlee) → review+
Attachment #561583 - Flags: review?(catlee) → review+
(In reply to Chris AtLee [:catlee] from comment #6)
> Comment on attachment 561585 [details] [diff] [review] [diff] [details] [review]
> tools v1
> 
> Review of attachment 561585 [details] [diff] [review] [diff] [details] [review]:
> -----------------------------------------------------------------
> 
> you need to update scripts in buildbot-helpers too (command_runner.py,
> pulse_publisher.py)

this tools patch looks to be just removing files, and not contain any info for the new files. Should be all hg moves of course...
Posted patch tools v2Splinter Review
hg rename of buildtools to mozilla_buildtools and changed the imports for buildbot-helpers scripts that use it.
Attachment #561585 - Attachment is obsolete: true
Attachment #565269 - Flags: review?(catlee)
Attachment #565269 - Flags: review?(catlee) → review+
Comment on attachment 561583 [details] [diff] [review]
buildbot-configs v1

backed out because of checkconfig errors in production (schedulers) -- need to check this
Attachment #561583 - Flags: checked-in+
Comment on attachment 561584 [details] [diff] [review]
buildbotcustom v1

backed out for now
Attachment #561584 - Flags: checked-in+
Comment on attachment 565269 [details] [diff] [review]
tools v2

backed out for now
Attachment #565269 - Flags: checked-in+
Posted patch buildbot-configs v2 (obsolete) — Splinter Review
missing updated buildtools rename in universal & scheduler master.cfg
Assignee: jhford → lsblakk
Attachment #561583 - Attachment is obsolete: true
Attachment #565578 - Flags: review?(catlee)
caught some missing master.cfg in mozilla-tests too
Attachment #565578 - Attachment is obsolete: true
Attachment #565578 - Flags: review?(catlee)
Attachment #565579 - Flags: review?(catlee)
Attachment #565579 - Flags: review?(catlee) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.