688296 - buildtools python module conflicts with an xcode provided python module

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

/tools/lib/python/buildtools/__init__.py conflicts with a python module provided by Xcode, /System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/plat-mac/buildtools.py

This causes import exceptions when running buildbot on my Mac system.  It also complicates things for anyone looking to do mozilla buildbot development on their mac system.  I am using a virtualenv, but rely on system site packages because some of the modules I have need special compile steps with Xcode 4.

Lets rename this module to something else that doesn't conflict with system packages.


Traceback (most recent call last):
  File "/Users/jhford/mozilla/puppet-10.6/lib/python2.6/site-packages/buildbot-0.8.2_hg_93b5fefe8474_default-py2.6.egg/buildbot/scripts/runner.py", line 1039, in doCheckConfig
    ConfigLoader(configFileName=configFileName)
  File "/Users/jhford/mozilla/puppet-10.6/lib/python2.6/site-packages/buildbot-0.8.2_hg_93b5fefe8474_default-py2.6.egg/buildbot/scripts/checkconfig.py", line 31, in __init__
    self.loadConfig(configFile, check_synchronously_only=True)
  File "/Users/jhford/mozilla/puppet-10.6/lib/python2.6/site-packages/buildbot-0.8.2_hg_93b5fefe8474_default-py2.6.egg/buildbot/master.py", line 628, in loadConfig
    exec f in localDict
  File "/Users/jhford/mozilla/puppet-10.6/test-master/master.cfg", line 5, in <module>
    import buildbotcustom.misc
  File "/Users/jhford/mozilla/puppet-10.6/buildbotcustom/misc.py", line 31, in <module>
    import buildtools.queuedir
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/plat-mac/buildtools.py", line 18, in <module>
    import EasyDialogs
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/plat-mac/EasyDialogs.py", line 24, in <module>
    from Carbon.Dlg import GetNewDialog, SetDialogItemText, GetDialogItemText, ModalDialog
ImportError: cannot import name GetNewDialog

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbot-configs v1

This corrects buildbotcustom imports

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbotcustom v1

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: tools v1

Comment 4

[Chris Cooper [:coop] (he/him)]

jhford: is this blocking any other work? I'm worried specifically about bug 681726.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

It means that I am unable to test my patches locally while this issue is open, which makes it very slow to work on the buildbot patches.

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 561585 [details] [diff] [review]
tools v1

Review of attachment 561585 [details] [diff] [review]:
-----------------------------------------------------------------

you need to update scripts in buildbot-helpers too (command_runner.py, pulse_publisher.py)

Comment 7

[Justin Wood (:Callek)]

(In reply to Chris AtLee [:catlee] from comment #6)
> Comment on attachment 561585 [details] [diff] [review] [diff] [details] [review]
> tools v1
> 
> Review of attachment 561585 [details] [diff] [review] [diff] [details] [review]:
> -----------------------------------------------------------------
> 
> you need to update scripts in buildbot-helpers too (command_runner.py,
> pulse_publisher.py)

this tools patch looks to be just removing files, and not contain any info for the new files. Should be all hg moves of course...

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: tools v2

hg rename of buildtools to mozilla_buildtools and changed the imports for buildbot-helpers scripts that use it.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 561584 [details] [diff] [review]
buildbotcustom v1

http://hg.mozilla.org/build/buildbotcustom/rev/da511c2cc325

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 561583 [details] [diff] [review]
buildbot-configs v1

http://hg.mozilla.org/build/buildbot-configs/rev/224a9fc20efd

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 565269 [details] [diff] [review]
tools v2

http://hg.mozilla.org/build/tools/rev/a38d61834627

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 561583 [details] [diff] [review]
buildbot-configs v1

backed out because of checkconfig errors in production (schedulers) -- need to check this

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 561584 [details] [diff] [review]
buildbotcustom v1

backed out for now

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 565269 [details] [diff] [review]
tools v2

backed out for now

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: buildbot-configs v2

missing updated buildtools rename in universal & scheduler master.cfg

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: buildbot-configs v3

caught some missing master.cfg in mozilla-tests too

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 561584 [details] [diff] [review]
buildbotcustom v1

http://hg.mozilla.org/build/buildbotcustom/rev/cb986ed96685 in production

Comment 18

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 565579 [details] [diff] [review]
buildbot-configs v3

http://hg.mozilla.org/build/buildbot-configs/rev/f2c48b76eb44 in production

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 565269 [details] [diff] [review]
tools v2

http://hg.mozilla.org/build/tools/rev/5d7275ae3207 in production, resolving.