688357 - [SeaMonkey] Windows Build Failure due to Bug 648581

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Justin Wood (:Callek)]

Bug 648581 broke SeaMonkey by adding crashreporter annotations in a codepath we can't add them from.

Firefox gets around this by using a newer startup path, and Thunderbird fixed this breakage by morphing some/all of that new startup path into their code in one fell swoop.

I do plan to do that startup work in a week or two, but have not begun it yet, and rather than introduce potential further issues when trying to fix a bustage, I have a simpler [Temporary] solution.

My solution eliminates the ability for us (SeaMonkey Only) to add a CrashReporter annotation in the case of a failed DLL Blocklist load. (Which is entirely new with this m-c patch anyway, so is ok for SeaMonkey)

Asking kyle to review both these patches (c-c and m-c) since it is build-system in the end, and NPOTDB for firefox.

Comment 1

[Justin Wood (:Callek)]

Attachment: c-c patch

Comment 2

[Justin Wood (:Callek)]

Attachment: m-c patch

Comment 3

[Justin Wood (:Callek)]

http://hg.mozilla.org/mozilla-central/rev/1985330ca298
http://hg.mozilla.org/comm-central/rev/dfe1e3af4773