Closed
Bug 688377
Opened 13 years ago
Closed 12 years ago
about:license always contains license information about DirectX dlls
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: glandium, Assigned: gerv)
References
Details
These files aren't shipped when ANGLE is not enabled, and more importantly, are not shipped on non Windows builds, where the about:license snipped about them is irrelevant.
Comment 1•13 years ago
|
||
I believe that is why the following is included above the licenses. "(Note: your copy of this product may not contain code covered by one or more of the licenses listed here, depending on the exact product and version you choose)" I think this is wontfix per the above. Gerv, can you confirm?
Assignee | ||
Comment 2•13 years ago
|
||
As you say, the text you quote is included in about:licence for precisely this reason. It was considered not worth the effort to write a system to make about:licence be dynamically constructed at build time (which is what you would need). Gerv
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Reporter | ||
Comment 3•13 years ago
|
||
(In reply to Robert Strong [:rstrong] (do not email) from comment #1) > I believe that is why the following is included above the licenses. > "(Note: your copy of this product may not contain code covered by one or > more of the licenses listed here, depending on the exact product and version > you choose)" > > I think this is wontfix per the above. I think it shouldn't, because contrary to the other licenses listed in the same file, these are *not* free software licenses.
Reporter | ||
Comment 4•13 years ago
|
||
(In reply to Gervase Markham [:gerv] from comment #2) > As you say, the text you quote is included in about:licence for precisely > this reason. It was considered not worth the effort to write a system to > make about:licence be dynamically constructed at build time (which is what > you would need). There already is: #ifdef APP_LICENSE_BLOCK #includesubst @APP_LICENSE_BLOCK@ #endif in the license.html file, which means it's preprocessed already. Please reconsider.
Assignee | ||
Comment 5•13 years ago
|
||
Hmm. A fair point. I have a bug open to tidy up this file anyway; at the very least, sadly-necessary non-free stuff should have its own section. Gerv
Assignee: nobody → gerv
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Assignee | ||
Comment 6•12 years ago
|
||
glandium: are you able to give me the correct magic preprocessor incantations to put around the Windows-only license blocks? Gerv
Reporter | ||
Comment 7•12 years ago
|
||
XP_WIN should be good.
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/54ff182dd2f3 Gerv
Status: REOPENED → RESOLVED
Closed: 13 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•