Last Comment Bug 688416 - Test for Bug 502959 relies on XHR event listener being an nsIDOMEventListener
: Test for Bug 502959 relies on XHR event listener being an nsIDOMEventListener
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla10
Assigned To: Kyle Huey [:khuey] (khuey@mozilla.com)
:
Mentors:
Depends on:
Blocks: 502959 687332
  Show dependency treegraph
 
Reported: 2011-09-22 05:08 PDT by Kyle Huey [:khuey] (khuey@mozilla.com)
Modified: 2011-09-29 09:16 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (677 bytes, patch)
2011-09-22 05:08 PDT, Kyle Huey [:khuey] (khuey@mozilla.com)
no flags Details | Diff | Review
Patch (1.20 KB, patch)
2011-09-26 15:03 PDT, Kyle Huey [:khuey] (khuey@mozilla.com)
mrbkap: review+
Details | Diff | Review

Description Kyle Huey [:khuey] (khuey@mozilla.com) 2011-09-22 05:08:12 PDT
Created attachment 561705 [details] [diff] [review]
Patch

The test for Bug 502959 expects that if it sets and then retrieves the onreadystatechange event handler on an XHR object that it will receive a wrapped nsIDOMEventListener.  After Bug 687332 this is no longer the case.

Wrappers scare me, so asking for r+ on this test change to make sure it's still testing what it should be.
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-09-26 14:11:04 PDT
Comment on attachment 561705 [details] [diff] [review]
Patch

So, now that I understand what this test does I think I know how to continue testing that functionality.
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-09-26 15:03:28 PDT
Created attachment 562552 [details] [diff] [review]
Patch

What do you know, dom traversal *is* actually good for something!
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-09-29 09:16:42 PDT
https://hg.mozilla.org/mozilla-central/rev/79f7d54a4cc3

Note You need to log in before you can comment on or make changes to this bug.