Test for Bug 502959 relies on XHR event listener being an nsIDOMEventListener

RESOLVED FIXED in mozilla10

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

unspecified
mozilla10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 561705 [details] [diff] [review]
Patch

The test for Bug 502959 expects that if it sets and then retrieves the onreadystatechange event handler on an XHR object that it will receive a wrapped nsIDOMEventListener.  After Bug 687332 this is no longer the case.

Wrappers scare me, so asking for r+ on this test change to make sure it's still testing what it should be.
Attachment #561705 - Flags: review?(mrbkap)
Comment on attachment 561705 [details] [diff] [review]
Patch

So, now that I understand what this test does I think I know how to continue testing that functionality.
Attachment #561705 - Attachment is obsolete: true
Attachment #561705 - Flags: review?(mrbkap)
Created attachment 562552 [details] [diff] [review]
Patch

What do you know, dom traversal *is* actually good for something!
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #562552 - Flags: review?(mrbkap)

Updated

6 years ago
Attachment #562552 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/79f7d54a4cc3
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.