Last Comment Bug 688417 - Test for Bug 505915 expects setting XHR.onreadystatechange to cause unwrapping of the object passed in
: Test for Bug 505915 expects setting XHR.onreadystatechange to cause unwrappin...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla10
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks: 505915 687332
  Show dependency treegraph
 
Reported: 2011-09-22 05:13 PDT by Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
Modified: 2011-09-29 09:18 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.13 KB, patch)
2011-09-22 05:13 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
mrbkap: review+
Details | Diff | Splinter Review

Description Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-09-22 05:13:35 PDT
Created attachment 561706 [details] [diff] [review]
Patch

I think that this test can just be removed.
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-09-22 12:56:17 PDT
So what happens here is that the onfoo setter looks at the object passed in, determines that it's not a function, and bails with NS_OK.  So we're still not setting an event listener here, we're just not throwing anymore.  This is consistent with how onfoo behaves on Nodes.
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-09-29 09:18:11 PDT
https://hg.mozilla.org/mozilla-central/rev/78fb73454cac

Note You need to log in before you can comment on or make changes to this bug.