688446 - Timeout Error - Modal dialog has been found and processed when using blocklist.xul window

Status: RESOLVED INVALID

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Remus Pop (:RemusPop)]

Attachment: testcase

I have attached a testcase which is a patch. Just import it to a clean repo.
It installs a local extension (icons.xpi) and blocklists it. After restart (test2.js) we ping the blocklist and we get a modal dialog indicating that there are some troubles with our installed extension.
To run the applied patch, run "mozmill-restart -t tests/functional/restartTests/testAddons_installUninstallBlocklisted/ -b "PATH_TO_FIREFOX"

The dialog that appears cannot be fetched - "TimeoutError(\"Modal dialog has been found and processed\").
This is reproducible for beta, aurora and nightly. Release is ok.

I also noticed that if I run nighlty, aurora or beta through mozmill (command: mozmill -b "~/firefox-BRANCH/firefox") I have errors in the errors console.
Errors come from the mozmill extension that is installed when running mozmill. I am getting this:
Error: doc.defaultView is undefined
Source File: resource://mozmill/modules/init.js
Line: 74

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

There is no need to use the error console here to trigger a ping. Call the code directly from within your test. Also it could be that this dialog doesn't have a window opener set, so try to use the constructor without a window parameter.

Comment 2

[Remus Pop (:RemusPop)]

Attachment: testcase

Here is a simplified version with pinging done in the background.

I have also removed the parameter from the constructor as it doesn't influence the finding of the modal dialog.

Again, in Firefox 6 (release) it works fine.

Comment 3

[Remus Pop (:RemusPop)]

I think this is the call that opens our modal-dialog:

let blocklistWindow = Services.ww.openWindow(null, URI_BLOCKLIST_DIALOG, "", "chrome,centerscreen,dialog,titlebar", args);

which can be found here:
http://hg.mozilla.org/releases/mozilla-aurora/file/223f39756a26/toolkit/mozapps/extensions/nsBlocklistService.js#l1053
Selected branch is Aurora.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Remus Pop (:RemusPop) from comment #3)
> let blocklistWindow = Services.ww.openWindow(null, URI_BLOCKLIST_DIALOG, "",
> "chrome,centerscreen,dialog,titlebar", args);

As you can see here the window doesn't get opened as modal. It's a normal window and it doesn't stop you from switching between windows. So you cannot use the modalDialog class here. Instead handleWindow has to be used.

-> Invalid.