Fix up nsIFrameMessageManager::sendAsyncMessage/nsISyncMessageSender::sendSyncMessage IDL signature

RESOLVED FIXED in mozilla10

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla10
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 561737 [details] [diff] [review]
Patch v1
Attachment #561737 - Flags: review?(bzbarsky)
Flags: in-testsuite-
Comment on attachment 561737 [details] [diff] [review]
Patch v1

You need to rev the iids.

>+ * the Mozilla FOundation.

s/O/o/

This patch is inconsistent about whether one casts between jschar* and PRUnichar* with static_cast or reinterpret_cast.  If the former works, stick with it!

>+          if (!JS_ParseJSON(ctx, reinterpret_cast<const jschar*>(nsString(aJSON).get()),

As long as you're here, PromiseFlatString(), please.

r=me with those nits.
Attachment #561737 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/c7ee75aca277
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10

Comment 3

5 years ago
(In reply to Boris Zbarsky from comment #1)
> (From update of attachment 561737 [details] [diff] [review])
> >+          if (!JS_ParseJSON(ctx, reinterpret_cast<const jschar*>(nsString(aJSON).get()),
> 
> As long as you're here, PromiseFlatString(), please.

Still wrong. aJSON.BeginReading() suffices, because we don't need the string to be terminated.
You need to log in before you can comment on or make changes to this bug.