Closed
Bug 68847
Opened 25 years ago
Closed 25 years ago
go to framed window, reload breaks back button
Categories
(Core :: DOM: Navigation, defect, P3)
Tracking
()
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: kiko, Assigned: radha)
References
Details
Attachments
(2 files)
|
321 bytes,
patch
|
Details | Diff | Splinter Review | |
|
1.37 KB,
patch
|
Details | Diff | Splinter Review |
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.1 i586; en-US; 0.8) Gecko/20010214
BuildID: 2001021403
Blocking image on a framed page and reloading breaks back button with a
JavaScript error:
line 0: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.goBack]" nsresult: "0x80004005
(NS_ERROR_FAILURE)" location: "JS frame ::
chrome://navigator/content/navigator.js :: BrowserBack :: line 572" data: no]
error!
Reproducible: Always
Steps to Reproduce:
Load up www.pro.com. Block the image on the top right of page. Reload.
Actual Results: Back button breaks.
Expected Results: Back button should work.
| Reporter | ||
Updated•25 years ago
|
Component: Browser-General → Cookies
Comment 1•25 years ago
|
||
setting bug status to New.
Assignee: asa → morse
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: doronr → tever
Updated•25 years ago
|
Target Milestone: --- → mozilla0.9
Updated•25 years ago
|
Status: NEW → ASSIGNED
Mass moving most of mozilla0.9 bugs to mozilla0.8.1
Target Milestone: mozilla0.9 → mozilla0.8.1
Updated•25 years ago
|
Target Milestone: mozilla0.8.1 → mozilla0.9
Comment 3•25 years ago
|
||
Changing OS from linux to all because I'm seeing this behavior on win32 also.
This has nothing to do with image blocking -- that was just a red herring. Try
the identical test but omit the block-image step and again the back button will
be broken. Removing the reference to block-image in the summary.
Also changing the component away from cookies (cookies is the defacto component
for image-blocking problems). I'd like to set the component to navigation but I
don't see such a component so I'm reassigning to browser-general.
FWIW, here's a clue. Prior to the reload, the list that appears when you click
the backbutton's arrow key starts off with the title of the previous page
visited. After the reload, that list starts off with three instances of "PCC
Artwork System" (which is the title of the www.pro.com page) and then comes the
title of the previous page visited.
Assignee: morse → asa
Status: ASSIGNED → NEW
Component: Cookies → Browser-General
OS: Linux → All
QA Contact: tever → doronr
Summary: block image in framed window, reload breaks back button → go to framed window, reload breaks back button
Comment 4•25 years ago
|
||
over to session history for triage.
Assignee: asa → radha
Component: Browser-General → History: Session
QA Contact: doronr → claudius
| Assignee | ||
Comment 5•25 years ago
|
||
My best guess is, this is dupe of bug 58906. I would like to wait until that is
fixed to look in to this.
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: mozilla0.9 → mozilla0.9.1
Comment 8•25 years ago
|
||
| Assignee | ||
Comment 9•25 years ago
|
||
May be maybe not. But i think fixing this will help 66203
| Assignee | ||
Comment 10•25 years ago
|
||
Comment 11•25 years ago
|
||
radha - patch doesnt look like a patch. could you take a look at it?
Comment 12•25 years ago
|
||
that's not a patch, that's a "cvs status"
| Assignee | ||
Comment 13•25 years ago
|
||
Comment 14•25 years ago
|
||
Please don't call it BrowserReallyReload but e.g. BrowserReloadWithFlags.
Could you explain to me the (conceptual) difference between nsIWebNavigation as
implemented by session history and nsIWebNavigation as implemented by docshell?
nsDocShell.cpp seems to call through to session history in some cases, and not
in others. Should we really directly be talking to session history here, or
should docshell provide that functionality to us?
Comment 15•25 years ago
|
||
I agree with jag's comments. r=mcafee if jag's comments are addressed.
| Assignee | ||
Comment 16•25 years ago
|
||
I will change the function name.
For other stuff,
The implementation of nsIwebnavigation by docshell and SH are pretty similar.
Docshell was the original implementor and holder of SH and it was the gateway
to history for JS. When we decided to abandon JS frame specific history,
everything got tied to the window specific SH. That's why docshell's
implementation of nsiWebNavigation just passes the request to SH. Embedding
applications and viewer (nobody knows if anyone still uses it) right now use the
docshell for history operations. I'm of the opinion that after factoring out
certain methods from the interface, docshell need not implement nsIWebNavigation
.
Reload is an exception from rest of the webNavigation operations. Specifically
because we have the "Reload frame" feature for the browser and JS has a
location.reload() mechanism. That is why nsDocShell::Reload() does not call in
to SH. But what ever nsDocShell::Reload() does is primarily to support these 2
operations and when a new cahrset detection forces a reload. Browser used to
call SH directly for its history operations, but when it was decided by the
browser team to get rid of nsBrowserInstance.cpp, it went away. I would prefer
browser to directly call SH, simply because it is cleaner and modular.
To sum it up, since Reload() is an exception from other history operations, the
patch attached to this bug directly calls in to SH to avoid mis-behavior on
frame pages. nsDocShell::Reload() is strictly to be called for "Reload frame",
location.reload() and charset detection based reloads.
Comment 17•25 years ago
|
||
sr=rpotts.
| Assignee | ||
Comment 18•25 years ago
|
||
This was fixed last friday
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 19•25 years ago
|
||
*** Bug 66203 has been marked as a duplicate of this bug. ***
Comment 20•25 years ago
|
||
VERIFIED FIxed with 2001061415 builds on all platforms
Status: RESOLVED → VERIFIED
Component: History: Session → Document Navigation
QA Contact: claudius → docshell
You need to log in
before you can comment on or make changes to this bug.
Description
•