Last Comment Bug 688551 - Fixing GCC 4.6 warnings from bug 684526
: Fixing GCC 4.6 warnings from bug 684526
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Linux
-- normal (vote)
: mozilla9
Assigned To: Igor Bukanov
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on: 684526
  Show dependency treegraph
Reported: 2011-09-22 11:40 PDT by Igor Bukanov
Modified: 2011-09-22 17:28 PDT (History)
10 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (1.04 KB, patch)
2011-09-22 11:40 PDT, Igor Bukanov
luke: review+
Details | Diff | Splinter Review

Description User image Igor Bukanov 2011-09-22 11:40:34 PDT
Created attachment 561810 [details] [diff] [review]

With the landing of the bug #684526 I got the warning on every include of jsapi.h:

/home/igor/m/mc/js/src/jsapi.h: In destructor ‘JS::Anchor<T>::~Anchor() [with T = JS::Value]’:
/home/igor/m/mc/js/src/jsapi.h:800:21: warning: variable ‘bits’ set but not used [-Wunused-but-set-variable]

The attached patch fixes that by specializing Anchor destructor for Value only outside GCC.
Comment 1 User image Luke Wagner [:luke] 2011-09-22 11:55:51 PDT
Comment on attachment 561810 [details] [diff] [review]

Oops; sorry.
Comment 3 User image Ed Morley [:emorley] 2011-09-22 17:28:09 PDT

Note You need to log in before you can comment on or make changes to this bug.