The default bug view has changed. See this FAQ.

Fixing GCC 4.6 warnings from bug 684526

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

Trunk
mozilla9
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 561810 [details] [diff] [review]
fix

With the landing of the bug #684526 I got the warning on every include of jsapi.h:

/home/igor/m/mc/js/src/jsapi.h: In destructor ‘JS::Anchor<T>::~Anchor() [with T = JS::Value]’:
/home/igor/m/mc/js/src/jsapi.h:800:21: warning: variable ‘bits’ set but not used [-Wunused-but-set-variable]

The attached patch fixes that by specializing Anchor destructor for Value only outside GCC.
Attachment #561810 - Flags: review?(luke)

Comment 1

6 years ago
Comment on attachment 561810 [details] [diff] [review]
fix

Oops; sorry.
Attachment #561810 - Flags: review?(luke) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/a35ab2401722
https://hg.mozilla.org/mozilla-central/rev/a35ab2401722
Assignee: nobody → igor
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.