Last Comment Bug 688551 - Fixing GCC 4.6 warnings from bug 684526
: Fixing GCC 4.6 warnings from bug 684526
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla9
Assigned To: Igor Bukanov
:
:
Mentors:
Depends on: 684526
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-22 11:40 PDT by Igor Bukanov
Modified: 2011-09-22 17:28 PDT (History)
10 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.04 KB, patch)
2011-09-22 11:40 PDT, Igor Bukanov
luke: review+
Details | Diff | Splinter Review

Description Igor Bukanov 2011-09-22 11:40:34 PDT
Created attachment 561810 [details] [diff] [review]
fix

With the landing of the bug #684526 I got the warning on every include of jsapi.h:

/home/igor/m/mc/js/src/jsapi.h: In destructor ‘JS::Anchor<T>::~Anchor() [with T = JS::Value]’:
/home/igor/m/mc/js/src/jsapi.h:800:21: warning: variable ‘bits’ set but not used [-Wunused-but-set-variable]

The attached patch fixes that by specializing Anchor destructor for Value only outside GCC.
Comment 1 Luke Wagner [:luke] 2011-09-22 11:55:51 PDT
Comment on attachment 561810 [details] [diff] [review]
fix

Oops; sorry.
Comment 3 Ed Morley [:emorley] 2011-09-22 17:28:09 PDT
https://hg.mozilla.org/mozilla-central/rev/a35ab2401722

Note You need to log in before you can comment on or make changes to this bug.