Last Comment Bug 688558 - Context Menu for Inspect Element can Create 2 Highlighters
: Context Menu for Inspect Element can Create 2 Highlighters
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: Firefox 9
Assigned To: Rob Campbell [:rc] (:robcee)
: J. Ryan Stinnett [:jryans] (use ni?)
: 682297 (view as bug list)
Depends on:
Blocks: 650794
  Show dependency treegraph
Reported: 2011-09-22 11:52 PDT by Rob Campbell [:rc] (:robcee)
Modified: 2011-10-27 09:15 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

[in-fx-team] re-entrant context menu test (5.10 KB, patch)
2011-09-22 11:52 PDT, Rob Campbell [:rc] (:robcee)
mihai.sucan: review+
Details | Diff | Splinter Review

Description Rob Campbell [:rc] (:robcee) 2011-09-22 11:52:10 PDT
Created attachment 561816 [details] [diff] [review]
[in-fx-team] re-entrant context menu test

During some integration testing, I found that one of my patches made it possible to create two Highlighter instances using the new Context Menu's Inspect Element item landed in bug 587134.

I wrote a test and some simple guard code in openInspectorUI() that my patch from bug 650794 breaks.
Comment 1 :Gavin Sharp [email:] 2011-09-22 11:57:49 PDT
Comment on attachment 561816 [details] [diff] [review]
[in-fx-team] re-entrant context menu test

We seem to inconsistently use isTreePanelOpen, or null checks of treeLoaded or highlighter for "is the inspector open". It would be nice to have a canonical way to check that and use it consistently.
Comment 2 Rob Campbell [:rc] (:robcee) 2011-09-22 12:03:02 PDT
Gavin, I think checking for the existence of InspectorUI.highlighter is going to be pretty reliable. It gets initialized at the end of everything else and should only be present when the Inspector/Highlighter is actually up and running. That's what I'm looking for in my updated patch for bug 650794.

I could create a getter in InspectorUI that verifies the existence of the highlighter and that it's inited properly. Prior to bug 650794, we also rely on the tree panel being properly initialized and that starts to get a little confusing.
Comment 3 Rob Campbell [:rc] (:robcee) 2011-09-22 12:04:06 PDT
I could morph this bug into "create a canonical getter in InspectorUI to determine if the Inspector is Up and Running". Want?
Comment 4 Mihai Sucan [:msucan] 2011-09-22 12:35:42 PDT
Comment on attachment 561816 [details] [diff] [review]
[in-fx-team] re-entrant context menu test

Review of attachment 561816 [details] [diff] [review]:

Patch looks fine, but I agree with Gavin about isTreePanelOpen.

In our megapatch we do have isPanelOpen (IIRC), which is the canonical way to check if the Inspector is open or not. So we can use that. It would be nice if this fix would be on top of the megapatch?
Comment 5 Rob Campbell [:rc] (:robcee) 2011-09-22 13:30:42 PDT
no, isPanelOpen or isTreePanelOpen are only useful for checking states of... panels! We want to know if the InspectorUI itself is up. I can create a method to do that.
Comment 6 Rob Campbell [:rc] (:robcee) 2011-09-23 15:29:33 PDT
Comment on attachment 561816 [details] [diff] [review]
[in-fx-team] re-entrant context menu test
Comment 7 Rob Campbell [:rc] (:robcee) 2011-09-23 15:47:02 PDT
Comment 8 Dão Gottwald [:dao] 2011-09-24 03:38:51 PDT
Backed out because of various new mochitest-browser-chrome leaks. Unfortunately, this landed with a bunch of other interweaved patches. I only felt comfortable ruling out f297a626dd13 and 7d5311c92e04.
Comment 9 Rob Campbell [:rc] (:robcee) 2011-09-26 10:39:09 PDT
Comment 10 Tim Taubert [:ttaubert] 2011-09-27 04:27:02 PDT
Comment 11 Teodosia Pop 2011-10-21 06:18:22 PDT
Verified Fixed using Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0a1) Gecko/20111020 Firefox/10.0a1.
Comment 12 Rob Campbell [:rc] (:robcee) 2011-10-27 09:15:47 PDT
*** Bug 682297 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.