The default bug view has changed. See this FAQ.

Wrong reg key used in Installer shell icon handler code

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Installer
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mcsmurf, Assigned: mcsmurf)

Tracking

Trunk
Firefox 11
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
The code at http://hg.mozilla.org/mozilla-central/annotate/45db8c3384e1/browser/installer/windows/nsis/shared.nsh#l389 looks wrong, the code should read "ReadRegStr $1 HKLM "Software\Classes\FirefoxHTML\DefaultIcon" """
(Assignee)

Comment 1

6 years ago
Created attachment 562137 [details] [diff] [review]
Patch
Assignee: nobody → bugzilla
Attachment #562137 - Flags: review?
(Assignee)

Comment 2

6 years ago
Created attachment 562148 [details] [diff] [review]
Patch
Attachment #562137 - Attachment is obsolete: true
Attachment #562137 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #562148 - Flags: review?(robert.bugzilla)
Attachment #562148 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Comment 3

5 years ago
Checked in: http://hg.mozilla.org/mozilla-central/rev/7e74a12601a4
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
You need to log in before you can comment on or make changes to this bug.