Last Comment Bug 688615 - Wrong reg key used in Installer shell icon handler code
: Wrong reg key used in Installer shell icon handler code
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Installer (show other bugs)
: Trunk
: x86 Windows XP
: -- normal (vote)
: Firefox 11
Assigned To: Frank Wein [:mcsmurf]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-22 14:32 PDT by Frank Wein [:mcsmurf]
Modified: 2011-12-14 13:43 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (71 bytes, patch)
2011-09-23 12:46 PDT, Frank Wein [:mcsmurf]
no flags Details | Diff | Review
Patch (682 bytes, patch)
2011-09-23 13:15 PDT, Frank Wein [:mcsmurf]
robert.strong.bugs: review+
Details | Diff | Review

Description Frank Wein [:mcsmurf] 2011-09-22 14:32:38 PDT
The code at http://hg.mozilla.org/mozilla-central/annotate/45db8c3384e1/browser/installer/windows/nsis/shared.nsh#l389 looks wrong, the code should read "ReadRegStr $1 HKLM "Software\Classes\FirefoxHTML\DefaultIcon" """
Comment 1 Frank Wein [:mcsmurf] 2011-09-23 12:46:42 PDT
Created attachment 562137 [details] [diff] [review]
Patch
Comment 2 Frank Wein [:mcsmurf] 2011-09-23 13:15:27 PDT
Created attachment 562148 [details] [diff] [review]
Patch
Comment 3 Frank Wein [:mcsmurf] 2011-12-14 13:43:00 PST
Checked in: http://hg.mozilla.org/mozilla-central/rev/7e74a12601a4

Note You need to log in before you can comment on or make changes to this bug.