Closed Bug 688615 Opened 10 years ago Closed 10 years ago

Wrong reg key used in Installer shell icon handler code

Categories

(Firefox :: Installer, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 11

People

(Reporter: mcsmurf, Assigned: mcsmurf)

Details

Attachments

(1 file, 1 obsolete file)

The code at http://hg.mozilla.org/mozilla-central/annotate/45db8c3384e1/browser/installer/windows/nsis/shared.nsh#l389 looks wrong, the code should read "ReadRegStr $1 HKLM "Software\Classes\FirefoxHTML\DefaultIcon" """
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → bugzilla
Attachment #562137 - Flags: review?
Attached patch PatchSplinter Review
Attachment #562137 - Attachment is obsolete: true
Attachment #562137 - Flags: review?
Attachment #562148 - Flags: review?(robert.bugzilla)
Attachment #562148 - Flags: review?(robert.bugzilla) → review+
Checked in: http://hg.mozilla.org/mozilla-central/rev/7e74a12601a4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
You need to log in before you can comment on or make changes to this bug.