js-ctypes access to JNI

RESOLVED FIXED in mozilla9

Status

()

Core
Widget: Android
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

Trunk
mozilla9
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 561899 [details] [diff] [review]
Unhide GetJNIForThread

As an extension author I need access to Android's platform API. The obvious way to do this is through js-ctypes.

Updated

6 years ago
Attachment #561899 - Flags: review?(doug.turner)
Hi Eitan, thanks for the patch. If you want to get review on the patch (which I assume you want), you should ask review on someone.
Status: UNCONFIRMED → NEW
Component: General → Widget: Android
Ever confirmed: true
Product: Fennec → Core
QA Contact: general → android
(Assignee)

Comment 2

6 years ago
Hey Martijn. I assume you just set that flag right ("review?") for Doug. Right? Or do I need to do anything else? Sorry for the bmo newbyness!
Yes, I just set review for Doug. You don't need to do anything anymore.

Comment 4

6 years ago
Comment on attachment 561899 [details] [diff] [review]
Unhide GetJNIForThread

this is fine -- but beware, i may change this symbol at anytime without warning. :-D

An alternative is to copy this function (all of it) into your support library.
Attachment #561899 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 5

6 years ago
Support library? wha?? I am hoping not to need one :)

Are we done with the review process? I could push it?
Yes, the review process id done. This can be checked in by someone who has check-in privileges (which is not you).
Ideally, you should make a mq patch, which includes your name and check-in comment (which at least should mention the bug nr):
- Add this in your .hgrc:
 [ui]
 username = First Last <email>
 [defaults]
 qnew = -U

- To edit the commit message of the patch:
hg qref -e

More info here (you also need to do some other stuff for the mq patch):
https://developer.mozilla.org/en/Mercurial_queues
Keywords: checkin-needed

Updated

6 years ago
Assignee: nobody → eitan

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/84df818f0d2e

Thanks for the patch :-)
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

Comment 8

5 years ago
Folks stumbling across this bug via google search for "JNI" and "js-ctypes" might be interested in eeejay's gist which puts most of the pieces together: https://gist.github.com/1236179

I'm working on a patch to https://github.com/mfinkle/skeleton-addon-fxandroid to connect a few more dots for those looking to use Android ADK functions from a Firefox Mobile/Android extension.
(Assignee)

Comment 9

5 years ago
Here is a more complete module:
https://github.com/eeejay/Talk-To-Me/blob/master/content/android_api.js

Comment 10

5 years ago
https://github.com/cscott/skeleton-addon-fxandroid/tree/jni also has a more complete module.
You need to log in before you can comment on or make changes to this bug.