Created attachment 561899 [details] [diff] [review]
As an extension author I need access to Android's platform API. The obvious way to do this is through js-ctypes.
Hi Eitan, thanks for the patch. If you want to get review on the patch (which I assume you want), you should ask review on someone.
Hey Martijn. I assume you just set that flag right ("review?") for Doug. Right? Or do I need to do anything else? Sorry for the bmo newbyness!
Yes, I just set review for Doug. You don't need to do anything anymore.
Comment on attachment 561899 [details] [diff] [review]
this is fine -- but beware, i may change this symbol at anytime without warning. :-D
An alternative is to copy this function (all of it) into your support library.
Support library? wha?? I am hoping not to need one :)
Are we done with the review process? I could push it?
Yes, the review process id done. This can be checked in by someone who has check-in privileges (which is not you).
Ideally, you should make a mq patch, which includes your name and check-in comment (which at least should mention the bug nr):
- Add this in your .hgrc:
username = First Last <email>
qnew = -U
- To edit the commit message of the patch:
hg qref -e
More info here (you also need to do some other stuff for the mq patch):
Thanks for the patch :-)
Folks stumbling across this bug via google search for "JNI" and "js-ctypes" might be interested in eeejay's gist which puts most of the pieces together: https://gist.github.com/1236179
I'm working on a patch to https://github.com/mfinkle/skeleton-addon-fxandroid to connect a few more dots for those looking to use Android ADK functions from a Firefox Mobile/Android extension.
Here is a more complete module:
https://github.com/cscott/skeleton-addon-fxandroid/tree/jni also has a more complete module.