688665 - automation.py.in should not be interpolated

Status: NEW

(Firefox Build System :: General, defect)

Description

[Jeff Hammel]

Having automation.py.in interpolated makes it less modular and more difficult to develop.  Most of the information from its interpolation is available elsewhere:

66 #expand _IS_WIN32 = len("__WIN32__") != 0
67 #expand _IS_MAC = __IS_MAC__ != 0
68 #expand _IS_LINUX = __IS_LINUX__ != 0
69 #ifdef IS_CYGWIN
70 #expand _IS_CYGWIN = __IS_CYGWIN__ == 1

^ These are available from mozinfo / writemozinfo.

76 #expand _PERL = __PERL__

^ This isn't used at all

The rest of the information can also be supplied.

Comment 1

[(not currently active) Ted Mielczarek]

_IS_CYGWIN is no longer used and should be removed. We should be pulling everything from mozinfo. The only thing we don't have currently is the default path to the binary, but we can provide that either in mozinfo or in some other fashion.